From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: move gfs2 tracepoints to inclue/trace/events dir
Date: Mon, 12 Oct 2009 10:43:03 +0100 [thread overview]
Message-ID: <1255340583.2675.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20091009234555.GA28257@infradead.org>
Hi,
On Fri, 2009-10-09 at 19:45 -0400, Christoph Hellwig wrote:
> On Fri, Oct 09, 2009 at 12:01:16PM -0400, Jason Baron wrote:
> > hi,
> >
> > I'd like to move the gfs2 tracepoints to the the common
> > include/trace/events directory along with all of the other trace events.
> > It makes understanding what tracepoints are available easier, and I see
> > no reason why gfs2 should be different. For example, 'ext4.h' is already
> > in the include/trace/events directory.
>
> Folks, no. Drivers and filesystems should be as self-contained as
> possible. include/trace/ is an extremly bad idea for everything that's
> not actually global kernel functionality. There's a reason all other
> fs headers have moved out of include/linux, too.
>
That true, although there is an argument about how much such a header
belongs to tracing and how much it belongs to the subsystem I think.
I'll drop the patch from my tree at the next update, until that can be
resolved,
Steve.
WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jason Baron <jbaron@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: move gfs2 tracepoints to inclue/trace/events dir
Date: Mon, 12 Oct 2009 10:43:03 +0100 [thread overview]
Message-ID: <1255340583.2675.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20091009234555.GA28257@infradead.org>
Hi,
On Fri, 2009-10-09 at 19:45 -0400, Christoph Hellwig wrote:
> On Fri, Oct 09, 2009 at 12:01:16PM -0400, Jason Baron wrote:
> > hi,
> >
> > I'd like to move the gfs2 tracepoints to the the common
> > include/trace/events directory along with all of the other trace events.
> > It makes understanding what tracepoints are available easier, and I see
> > no reason why gfs2 should be different. For example, 'ext4.h' is already
> > in the include/trace/events directory.
>
> Folks, no. Drivers and filesystems should be as self-contained as
> possible. include/trace/ is an extremly bad idea for everything that's
> not actually global kernel functionality. There's a reason all other
> fs headers have moved out of include/linux, too.
>
That true, although there is an argument about how much such a header
belongs to tracing and how much it belongs to the subsystem I think.
I'll drop the patch from my tree at the next update, until that can be
resolved,
Steve.
next prev parent reply other threads:[~2009-10-12 9:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 16:01 move gfs2 tracepoints to inclue/trace/events dir Jason Baron
2009-10-09 16:05 ` [Cluster-devel] " Steven Whitehouse
2009-10-09 16:05 ` Steven Whitehouse
2009-10-09 16:05 ` [Cluster-devel] " Steven Whitehouse
2009-10-09 16:20 ` Jason Baron
2009-10-09 16:28 ` [Cluster-devel] " Steven Whitehouse
2009-10-09 16:28 ` Steven Whitehouse
2009-10-09 16:28 ` [Cluster-devel] " Steven Whitehouse
2009-10-09 23:45 ` Christoph Hellwig
2009-10-09 23:45 ` Christoph Hellwig
2009-10-12 9:43 ` Steven Whitehouse [this message]
2009-10-12 9:43 ` Steven Whitehouse
2009-10-12 10:00 ` Ingo Molnar
2009-10-12 10:16 ` [Cluster-devel] " Steven Whitehouse
2009-10-12 10:16 ` Steven Whitehouse
2009-10-25 7:50 ` [Cluster-devel] " Christoph Hellwig
2009-10-25 7:50 ` Christoph Hellwig
2009-10-25 16:29 ` Ingo Molnar
2009-10-12 10:09 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255340583.2675.23.camel@localhost.localdomain \
--to=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.