From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tim Abbott <tabbott@ksplice.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
sam@ravnborg.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: powerpc problem with .data.page_aligned -> __page_aligned_data conversion
Date: Fri, 16 Oct 2009 07:00:09 +1100 [thread overview]
Message-ID: <1255636809.2347.103.camel@pasglop> (raw)
In-Reply-To: <alpine.DEB.1.10.0910151229340.25434@dr-wily.mit.edu>
On Thu, 2009-10-15 at 12:37 -0400, Tim Abbott wrote:
> Just to make sure I understand the nature of the problem, is the
> current
> breakage that gcc < 4.3 will _warn_ on any compilation units on ppc64
> that
> use __page_aligned data, or something worse?
>
> The cropping is clearly a potential problem, but I read the rest of
> your
> email as saying that the cropping of the alignment isn't actually a
> problem with the current kernel because the kernel is currently only
> using
> the macro with things whose size is divisible by PAGE_SIZE. However,
> I am
> not sure how to reconcile that with using the word "break" above...
Break is because we use -Werror on arch/powerpc :-)
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Tim Abbott <tabbott@ksplice.com>
Cc: sam@ravnborg.org, linuxppc-dev@lists.ozlabs.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: powerpc problem with .data.page_aligned -> __page_aligned_data conversion
Date: Fri, 16 Oct 2009 07:00:09 +1100 [thread overview]
Message-ID: <1255636809.2347.103.camel@pasglop> (raw)
In-Reply-To: <alpine.DEB.1.10.0910151229340.25434@dr-wily.mit.edu>
On Thu, 2009-10-15 at 12:37 -0400, Tim Abbott wrote:
> Just to make sure I understand the nature of the problem, is the
> current
> breakage that gcc < 4.3 will _warn_ on any compilation units on ppc64
> that
> use __page_aligned data, or something worse?
>
> The cropping is clearly a potential problem, but I read the rest of
> your
> email as saying that the cropping of the alignment isn't actually a
> problem with the current kernel because the kernel is currently only
> using
> the macro with things whose size is divisible by PAGE_SIZE. However,
> I am
> not sure how to reconcile that with using the word "break" above...
Break is because we use -Werror on arch/powerpc :-)
Ben.
next prev parent reply other threads:[~2009-10-15 20:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 5:32 powerpc problem with .data.page_aligned -> __page_aligned_data conversion Benjamin Herrenschmidt
2009-10-15 5:32 ` Benjamin Herrenschmidt
2009-10-15 16:37 ` Tim Abbott
2009-10-15 16:37 ` Tim Abbott
2009-10-15 20:00 ` Benjamin Herrenschmidt [this message]
2009-10-15 20:00 ` Benjamin Herrenschmidt
2009-10-15 16:46 ` Tim Abbott
2009-10-15 16:46 ` Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255636809.2347.103.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.