From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] deadloop in grub_ext2_iterate_dir
Date: Sat, 17 Oct 2009 14:54:24 +0200 [thread overview]
Message-ID: <1255784064.3373.23.camel@fz.local> (raw)
In-Reply-To: <4AD9B5F0.40304@parallels.com>
Am Samstag, den 17.10.2009, 16:17 +0400 schrieb Vasily Averin:
> + if (grub_le_to_cpu16 (dirent.direntlen) == 0)
> + return 0;
> +
> if (dirent.namelen != 0)
For consistency we should either always use the grub_Xe_to_cpuYZ
functions or never when checking for a 0 value.
Oh and in my first reply I forgot to tell you, that we prefer to have
GNU Changelog entries sent along with patches.
A git Signed-off-by line is useless. We use SVN not git as our main
repository.
--
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer
next prev parent reply other threads:[~2009-10-17 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 12:17 [patch] deadloop in grub_ext2_iterate_dir Vasily Averin
2009-10-17 12:54 ` Felix Zielcke [this message]
2009-10-24 23:37 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255784064.3373.23.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.