From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] Support RAID on virtio devices, and others
Date: Sun, 25 Oct 2009 10:37:01 +0100 [thread overview]
Message-ID: <1256463421.3277.14.camel@fz.local> (raw)
In-Reply-To: <4AE41A15.7050504@gmail.com>
Am Sonntag, den 25.10.2009, 10:27 +0100 schrieb Vladimir 'phcoder'
Serbinenko:
> > find_root_device in util/getroot.c seemed to be exactly what I
> wanted:
> > it just trawls /dev for the appropriate major and minor numbers.
> This
> > code is not performance-critical, so that should be fine.
> Not true. Even in current state grub-mkconfig is taking considerable
> time to complete on my system with numerous kernels. Unless someone
> implements a cache (it can be invalidated after 5 minutes) not to go
> through the same probing procedure on every grub-probe call I object
> against adding any additional delay in probing procedure
We have a bug report in Debian[0] open that grub-probe is very slow due
to the use of ioctl(BLKFLSBUF)
A comment above it says this is needed due to a bug in the Linux kernel.
Is there a safe way to check if this is still needed with a recent
Kernel?
This seems to be added 2003, so things could have changed now a bit.
[0] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=508834
--
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer
next prev parent reply other threads:[~2009-10-25 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-25 0:36 [PATCH] Support RAID on virtio devices, and others Colin Watson
2009-10-25 9:27 ` Vladimir 'phcoder' Serbinenko
2009-10-25 9:37 ` Felix Zielcke [this message]
2009-10-25 13:13 ` Robert Millan
2009-10-25 11:20 ` Colin Watson
2009-10-25 13:15 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256463421.3277.14.camel@fz.local \
--to=fzielcke@z-51.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.