All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vasu Dev <vasu.dev-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: James Bottomley
	<James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
Cc: christof.schmitt-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
	devel-s9riP+hp16TNLxjTenLetw@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 1/7] scsi-ml: modify change_queue_depth to take in reason why it is being called
Date: Wed, 28 Oct 2009 18:43:07 -0700	[thread overview]
Message-ID: <1256780587.16472.134.camel@vi2.jf.intel.com> (raw)
In-Reply-To: <1256770118.2989.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

On Wed, 2009-10-28 at 22:48 +0000, James Bottomley wrote:
> On Thu, 2009-10-15 at 17:46 -0700, Vasu Dev wrote:
> This still doesn't build:
> 
> drivers/scsi/53c700.c: In function 'NCR_700_detect':
> drivers/scsi/53c700.c:331: warning: assignment from incompatible pointer type
> drivers/scsi/53c700.c: At top level:
> drivers/scsi/53c700.c:2085: error: conflicting types for 'NCR_700_change_queue_depth'
> drivers/scsi/53c700.c:178: error: previous declaration of 'NCR_700_change_queue_depth' was here
> 

Too bad, I tried "make allmodconfig" again after "make distclean" on
x86_64 but again it didn't catch this error since it didn't compile
53c700.c once again, so any trick to really force all modules
compilation to catch such errors in future ?

> It looks like just an unconverted function prototype, so the patch below fixes it.
> 

Thanks James for the fix and I suppose I don't need to send updated
patch again with your fix since probably you will roll this fix into
this patch when applying this patch.

	Vasu

      parent reply	other threads:[~2009-10-29  1:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-16  0:46 [PATCH v2 1/7] scsi-ml: modify change_queue_depth to take in reason why it is being called Vasu Dev
     [not found] ` <20091016004639.22451.76363.stgit-M4Lc0Xp98oKtqXYlAKuG4QC/G2K4zDHf@public.gmane.org>
2009-10-16  0:46   ` [PATCH v2 2/7] scsi error: have scsi-ml call change_queue_depth to handle QUEUE_FULL Vasu Dev
2009-10-16  0:46   ` [PATCH v2 3/7] libfc: convert libfc calling scsi_track_queue_full Vasu Dev
2009-10-16  0:46   ` [PATCH v2 4/7] fcoe, libfc: fix an libfc issue with queue ramp down in libfc Vasu Dev
2009-10-16  0:47   ` [PATCH v2 5/7] scsi-ml: adds queue_depth ramp up code Vasu Dev
     [not found]     ` <20091016004700.22451.42962.stgit-M4Lc0Xp98oKtqXYlAKuG4QC/G2K4zDHf@public.gmane.org>
2009-10-16  9:29       ` Christof Schmitt
     [not found]         ` <20091016092912.GA7199-VuU8Q2ydlaqCpDFQwvYvMTJtLkR7yuzc@public.gmane.org>
2009-10-16 18:16           ` Vasu Dev
2009-10-16 23:08     ` [PATCH v3] " Vasu Dev
     [not found]       ` <20091016230824.18916.84116.stgit-M4Lc0Xp98oKtqXYlAKuG4QC/G2K4zDHf@public.gmane.org>
2009-10-20 18:54         ` Christof Schmitt
2009-10-20 22:32           ` Vasu Dev
2009-10-20 23:14             ` [Open-FCoE] " Joe Eykholt
     [not found]               ` <4ADE444D.5090307-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2009-10-21  7:49                 ` Christof Schmitt
2009-10-21 17:45                   ` [Open-FCoE] " Vasu Dev
     [not found]                   ` <20091021074944.GA3563-VuU8Q2ydlaqCpDFQwvYvMTJtLkR7yuzc@public.gmane.org>
2009-10-21 17:54                     ` Giridhar Malavali
2009-10-21 13:11               ` [Open-FCoE] " James Smart
2009-10-21 13:37             ` Michael Reed
2009-10-22 22:46     ` [PATCH v4 5/7] " Vasu Dev
2009-10-23 13:53       ` Christof Schmitt
2009-10-23 17:51         ` Giridhar Malavali
2009-10-16  0:47   ` [PATCH v2 6/7] libfc: adds queue_depth ramp up to libfc Vasu Dev
2009-10-16  0:47   ` [PATCH v2 7/7] zfcp: Adapt change_queue_depth for queue full tracking Vasu Dev
2009-10-28 22:48   ` [PATCH v2 1/7] scsi-ml: modify change_queue_depth to take in reason why it is being called James Bottomley
     [not found]     ` <1256770118.2989.24.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-10-29  1:43       ` Vasu Dev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256780587.16472.134.camel@vi2.jf.intel.com \
    --to=vasu.dev-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
    --cc=christof.schmitt-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=devel-s9riP+hp16TNLxjTenLetw@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.