From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
linuxppc-dev@lists.ozlabs.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Filtering bits in set_pte_at()
Date: Tue, 03 Nov 2009 12:22:26 +1100 [thread overview]
Message-ID: <1257211346.7907.60.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.0911022342070.30581@sister.anvils>
On Mon, 2009-11-02 at 23:45 +0000, Hugh Dickins wrote:
> > IE. update_mmu_cache() would be more generally useful if it took the
> > ptep instead of the pte. Of course, I'm sure some embedded archs are
> > going to cry for the added load here ...
> >
> > I like your idea. I'll look into doing a patch converting it and
> will
> > post it here.
>
> Well, I wasn't proposing
>
> update_mmu_cache(vma, address, ptep);
> but
> update_mmu_cache(vma, address, *ptep);
>
> which may not meet your future idea, but is much less churn for now
> i.e. no change to any of the arch's update_mmu_cache(),
> just a change to some of its callsites.
I see... but if we go that way, I think we may as well do the whole
churn... I'll have a look at how bad it is.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: Filtering bits in set_pte_at()
Date: Tue, 03 Nov 2009 12:22:26 +1100 [thread overview]
Message-ID: <1257211346.7907.60.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.0911022342070.30581@sister.anvils>
On Mon, 2009-11-02 at 23:45 +0000, Hugh Dickins wrote:
> > IE. update_mmu_cache() would be more generally useful if it took the
> > ptep instead of the pte. Of course, I'm sure some embedded archs are
> > going to cry for the added load here ...
> >
> > I like your idea. I'll look into doing a patch converting it and
> will
> > post it here.
>
> Well, I wasn't proposing
>
> update_mmu_cache(vma, address, ptep);
> but
> update_mmu_cache(vma, address, *ptep);
>
> which may not meet your future idea, but is much less churn for now
> i.e. no change to any of the arch's update_mmu_cache(),
> just a change to some of its callsites.
I see... but if we go that way, I think we may as well do the whole
churn... I'll have a look at how bad it is.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: Filtering bits in set_pte_at()
Date: Tue, 03 Nov 2009 12:22:26 +1100 [thread overview]
Message-ID: <1257211346.7907.60.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.0911022342070.30581@sister.anvils>
On Mon, 2009-11-02 at 23:45 +0000, Hugh Dickins wrote:
> > IE. update_mmu_cache() would be more generally useful if it took the
> > ptep instead of the pte. Of course, I'm sure some embedded archs are
> > going to cry for the added load here ...
> >
> > I like your idea. I'll look into doing a patch converting it and
> will
> > post it here.
>
> Well, I wasn't proposing
>
> update_mmu_cache(vma, address, ptep);
> but
> update_mmu_cache(vma, address, *ptep);
>
> which may not meet your future idea, but is much less churn for now
> i.e. no change to any of the arch's update_mmu_cache(),
> just a change to some of its callsites.
I see... but if we go that way, I think we may as well do the whole
churn... I'll have a look at how bad it is.
Cheers,
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-11-03 1:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 2:44 Filtering bits in set_pte_at() Benjamin Herrenschmidt
2009-10-31 2:44 ` Benjamin Herrenschmidt
2009-10-31 2:44 ` Benjamin Herrenschmidt
2009-11-02 13:27 ` Hugh Dickins
2009-11-02 13:27 ` Hugh Dickins
2009-11-02 13:27 ` Hugh Dickins
2009-11-02 22:19 ` Benjamin Herrenschmidt
2009-11-02 22:19 ` Benjamin Herrenschmidt
2009-11-02 22:19 ` Benjamin Herrenschmidt
2009-11-02 23:45 ` Hugh Dickins
2009-11-02 23:45 ` Hugh Dickins
2009-11-02 23:45 ` Hugh Dickins
2009-11-03 1:22 ` Benjamin Herrenschmidt [this message]
2009-11-03 1:22 ` Benjamin Herrenschmidt
2009-11-03 1:22 ` Benjamin Herrenschmidt
2009-11-04 3:22 ` David Gibson
2009-11-04 3:22 ` David Gibson
2009-11-04 3:22 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257211346.7907.60.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.