From: Ben Hutchings <ben@decadent.org.uk>
To: David Miller <davem@davemloft.net>
Cc: david-b@pacbell.net, greg@kroah.com, jacmet@sunsite.dk,
steve.glendinning@smsc.com, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown
Date: Wed, 04 Nov 2009 03:20:00 +0000 [thread overview]
Message-ID: <1257304800.3136.452.camel@localhost> (raw)
In-Reply-To: <20091103.020444.120631587.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Tue, 2009-11-03 at 02:04 -0800, David Miller wrote:
> From: David Brownell <david-b@pacbell.net>
> Date: Tue, 3 Nov 2009 02:41:27 -0700
>
> > On Tuesday 03 November 2009, David Miller wrote:
> >> All kidding aside, I think the alternative is for the USB network
> >> driver to call ethtool_op_get_link() if it cannot determine the
> >> link state in hardware.
> >
> > There's usbnet_get_link() which does just that. But
> > there may be some ancient debris confusing things.
>
> It's perfect, and Ben's patch is completely unnecessary.
I don't see how it's 'perfect' since it reports the link as up where it
is really unknown. Still, this is a fairly minor bug.
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2009-11-04 3:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 3:26 [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown Ben Hutchings
2009-11-03 6:01 ` David Brownell
2009-11-03 9:01 ` David Miller
2009-11-03 9:41 ` David Brownell
2009-11-03 10:04 ` David Miller
2009-11-04 3:20 ` Ben Hutchings [this message]
2009-11-04 8:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257304800.3136.452.camel@localhost \
--to=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=jacmet@sunsite.dk \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.