From: David Brownell <david-b@pacbell.net>
To: David Miller <davem@davemloft.net>
Cc: ben@decadent.org.uk, greg@kroah.com, jacmet@sunsite.dk,
steve.glendinning@smsc.com, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown
Date: Tue, 3 Nov 2009 02:41:27 -0700 [thread overview]
Message-ID: <200911030141.27905.david-b@pacbell.net> (raw)
In-Reply-To: <20091103.010129.100672838.davem@davemloft.net>
On Tuesday 03 November 2009, David Miller wrote:
> > Having two tables for this is needlessly ugly.
>
> Yes, it's really cruddy how the USB network driver tries to share
> so much state amongst such very different devices :-)
That framework just grew ... started out as one driver,
nearly ten years back (yow!!), then generalized. Folk
seemed to appreciate not reinventing some stuff. ;)
If it had started out with this many devices, it might have
looked more like a library. Sharing code implies sharing
at least some state representations; the balance could might
be worth shifting by now.
> All kidding aside, I think the alternative is for the USB network
> driver to call ethtool_op_get_link() if it cannot determine the
> link state in hardware.
There's usbnet_get_link() which does just that. But
there may be some ancient debris confusing things.
next prev parent reply other threads:[~2009-11-03 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 3:26 [PATCH] usbnet: Do not implement ethtool get_link() if link state is unknown Ben Hutchings
2009-11-03 6:01 ` David Brownell
2009-11-03 9:01 ` David Miller
2009-11-03 9:41 ` David Brownell [this message]
2009-11-03 10:04 ` David Miller
2009-11-04 3:20 ` Ben Hutchings
2009-11-04 8:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911030141.27905.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=jacmet@sunsite.dk \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.