All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: InKi Dae <daeinki@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Kyungmin Park <kmpark@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [patch] added brightness feature to lcd class.
Date: Tue, 10 Nov 2009 08:43:17 +0000	[thread overview]
Message-ID: <1257842597.29038.162.camel@dax.rpnet.com> (raw)
In-Reply-To: <90b950fc0911091926v32dc1c44n1018322390282bc0@mail.gmail.com>

On Tue, 2009-11-10 at 12:26 +0900, InKi Dae wrote:
> Thank you for your comments.
> 
> it is a good idea that lcd driver registers interfaces to lcd class
> and backlight class.
> but I think for AMOLED LCD Panel, backlight couldn't be real device so
> power on/off
> for backlight device doesn't make sense.

The backlight power control can just turn the backlight level down to
its lowest setting (off)?

> I had tried lcd driver registers interfaces to lcd class and backlight
> class as you said.
> and also backlight fake driver as Pavel said.

So you've tried this, what was the problem? Perhaps post this driver
code to illustrate your problem?

> but I thought to use my patch is more simple and effective.
> of course, this patch has a problem that it has different path from
> backlight class
> for controlling brightness.
> 
> how about creating symbolic link file for competiability?

Creating two ways to do something (with or without symlinks) is not
simple and effective for anything other than your driver.

Cheers,

Richard

  reply	other threads:[~2009-11-10  8:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02  8:50 [patch] added brightness feature to lcd class InKi Dae
2009-11-05 19:27 ` Pavel Machek
2009-11-07 12:43   ` InKi Dae
2009-11-07 16:48     ` Pavel Machek
2009-11-09 15:37       ` InKi Dae
2009-11-09 20:15         ` Pavel Machek
2009-11-09 23:18 ` Andrew Morton
2009-11-09 23:35 ` Richard Purdie
2009-11-10  3:26   ` InKi Dae
2009-11-10  8:43     ` Richard Purdie [this message]
2009-11-10 15:27       ` Matthew Garrett
2009-11-11  6:17       ` InKi Dae
2009-11-11  9:28         ` Richard Purdie
2009-11-13  3:13           ` InKi Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257842597.29038.162.camel@dax.rpnet.com \
    --to=rpurdie@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=daeinki@gmail.com \
    --cc=kmpark@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.