All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: InKi Dae <daeinki@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Kyungmin Park <kmpark@infradead.org>
Subject: Re: [patch] added brightness feature to lcd class.
Date: Sat, 7 Nov 2009 17:48:30 +0100	[thread overview]
Message-ID: <20091107164830.GA1586@ucw.cz> (raw)
In-Reply-To: <90b950fc0911070443s57d2ec5ehcb5c9cf9edcf8d8c@mail.gmail.com>

On Sat 2009-11-07 21:43:50, InKi Dae wrote:
> Thank you for your comments.
> 
> using backlight is good way in case of TFT-LCD Panel.
> because TFT-LCD Panel needs backlight device to light up.
> 
> but AMOLED LCD Panel doesn't need backlight device because lighting up itself.

I know. So what?

User wants to set brightness. Why should userspace know/care if it is
TFT or AMOLED?

I have this script:

#!/bin/bash
echo $1 > /sys/class/backlight/*/brightness 

why should I have to rewrite it just because you decided amoled is
special?

Kernel is expected to provide hw abstraction...

									Pavel

									
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2009-11-07 16:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02  8:50 [patch] added brightness feature to lcd class InKi Dae
2009-11-05 19:27 ` Pavel Machek
2009-11-07 12:43   ` InKi Dae
2009-11-07 16:48     ` Pavel Machek [this message]
2009-11-09 15:37       ` InKi Dae
2009-11-09 20:15         ` Pavel Machek
2009-11-09 23:18 ` Andrew Morton
2009-11-09 23:35 ` Richard Purdie
2009-11-10  3:26   ` InKi Dae
2009-11-10  8:43     ` Richard Purdie
2009-11-10 15:27       ` Matthew Garrett
2009-11-11  6:17       ` InKi Dae
2009-11-11  9:28         ` Richard Purdie
2009-11-13  3:13           ` InKi Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091107164830.GA1586@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=daeinki@gmail.com \
    --cc=kmpark@infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.