All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
To: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL
Date: Fri, 13 Nov 2009 06:34:26 +0100	[thread overview]
Message-ID: <1258090466.3299.6.camel@violet> (raw)
In-Reply-To: <20090911051259.GC23210-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>

Hi Matthew,

> > Most laptops have keys that are intended to toggle all device state, not
> > just wifi. These are currently generally mapped to KEY_WLAN. As a result,
> > rfkill will only kill or enable wifi in response to the key press. This
> > confuses users and can make it difficult for them to enable bluetooth
> > and wwan devices.
> > 
> > This patch adds a new keycode, KEY_RFKILL_ALL. It indicates that the
> 
> The new name in description does not match the code...
> 
> > system should toggle the state of all rfkillable devices.
> 
> Hmm, rfkill changes usually go through net tree so unless they want me
> to push it though I'll just ACK the new keycode.
> 
> > 
> > Signed-off-by: Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> 
> Acked-by: Dmitry Torokhov <dtor-JGs/UdohzUI@public.gmane.org>

Acked-by: Marcel Holtmann <marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	linux-input@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL
Date: Fri, 13 Nov 2009 06:34:26 +0100	[thread overview]
Message-ID: <1258090466.3299.6.camel@violet> (raw)
In-Reply-To: <20090911051259.GC23210@core.coreip.homeip.net>

Hi Matthew,

> > Most laptops have keys that are intended to toggle all device state, not
> > just wifi. These are currently generally mapped to KEY_WLAN. As a result,
> > rfkill will only kill or enable wifi in response to the key press. This
> > confuses users and can make it difficult for them to enable bluetooth
> > and wwan devices.
> > 
> > This patch adds a new keycode, KEY_RFKILL_ALL. It indicates that the
> 
> The new name in description does not match the code...
> 
> > system should toggle the state of all rfkillable devices.
> 
> Hmm, rfkill changes usually go through net tree so unless they want me
> to push it though I'll just ACK the new keycode.
> 
> > 
> > Signed-off-by: Matthew Garrett <mjg@redhat.com>
> 
> Acked-by: Dmitry Torokhov <dtor@mail.ru>

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  parent reply	other threads:[~2009-11-13  5:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 17:21 [PATCH 1/2] input: Add KEY_RFKILL Matthew Garrett
2009-09-10 17:21 ` Matthew Garrett
     [not found] ` <1252603292-20830-1-git-send-email-mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2009-09-10 17:21   ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL Matthew Garrett
2009-09-10 17:21     ` Matthew Garrett
2009-11-13  5:33     ` Marcel Holtmann
2009-09-10 17:27   ` [PATCH 1/2] input: Add KEY_RFKILL Luis R. Rodriguez
2009-09-10 17:27     ` Luis R. Rodriguez
     [not found]     ` <43e72e890909101027saf1ed35u23936729eccf3f92-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-09-10 17:31       ` Matthew Garrett
2009-09-10 17:31         ` Matthew Garrett
2009-09-11  5:13 ` Dmitry Torokhov
     [not found]   ` <20090911051259.GC23210-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2009-11-13  5:34     ` Marcel Holtmann [this message]
2009-11-13  5:34       ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2010-02-16 21:36 Matthew Garrett
2010-02-16 23:05 ` Marcel Holtmann
2010-02-17  5:22 ` Dmitry Torokhov
     [not found]   ` <20100217052247.GD7160-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-17 18:03     ` Matthew Garrett
2010-02-17 18:03       ` Matthew Garrett
2010-02-17 18:43       ` Christian Lamparter
     [not found]         ` <22ee4e771002171043u2aaf97vd73c1090c2fce901-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 18:45           ` Matthew Garrett
2010-02-17 18:45             ` Matthew Garrett
2010-02-17 18:49             ` Bastien Nocera
     [not found]               ` <1266432575.678.980.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-02-17 22:34                 ` Peter Hutterer
2010-02-17 22:34                   ` Peter Hutterer
2010-02-18  4:16                   ` Dmitry Torokhov
     [not found]                     ` <20100218041636.GA19037-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-18  4:29                       ` Peter Hutterer
2010-02-18  4:29                         ` Peter Hutterer
2010-02-17 19:18             ` Christian Lamparter
2010-02-17 19:17         ` Dmitry Torokhov
     [not found]           ` <20100217191708.GA15554-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2010-02-17 19:42             ` Christian Lamparter
2010-02-17 19:42               ` Christian Lamparter
2010-02-17 19:54               ` Dmitry Torokhov
2010-02-17 20:02                 ` Matthew Garrett
2010-02-17 20:49                   ` Dmitry Torokhov
     [not found]                     ` <446821D4-8E9D-4701-9A50-04738C5733B6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-17 20:50                       ` Matthew Garrett
2010-02-17 20:50                         ` Matthew Garrett
2010-02-17 20:18                 ` Christian Lamparter
     [not found]                   ` <22ee4e771002171218t69cc4348ia0300a645ce9763d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 20:52                     ` Dmitry Torokhov
2010-02-17 20:52                       ` Dmitry Torokhov
     [not found]                       ` <069C4DAE-598D-45F1-99B5-DA5BAF718179-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-17 21:12                         ` pat-lkml-Jx9fsTfDDR3YtjvyW6yDsg
2010-02-17 21:12                           ` pat-lkml
2010-02-17 21:28                       ` Christian Lamparter
     [not found]                         ` <22ee4e771002171328w3c9cbb8n663c291e9d3634e5-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-17 21:40                           ` Dmitry Torokhov
2010-02-17 21:40                             ` Dmitry Torokhov
2010-02-17 22:03                             ` Christian Lamparter
     [not found]                               ` <22ee4e771002171403o6f0b99e8qd683d78e74fe4522-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-20  9:18                                 ` Dmitry Torokhov
2010-02-20  9:18                                   ` Dmitry Torokhov
2010-02-19 14:33                 ` Henrique de Moraes Holschuh
2010-02-17 19:18       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258090466.3299.6.camel@violet \
    --to=marcel-kz+m5ild9qbg9huczpvpmw@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.