From: Michael Ellerman <michael@ellerman.id.au>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4] powerpc: Add Kconfig dependency for PCI_MSI as needed by XICS
Date: Tue, 17 Nov 2009 23:40:10 +1100 [thread overview]
Message-ID: <1258461610.24093.74.camel@concordia> (raw)
In-Reply-To: <1258459659-11770-2-git-send-email-mel@csn.ul.ie>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Tue, 2009-11-17 at 12:07 +0000, Mel Gorman wrote:
> It's possible to set CONFIG_XICS without CONFIG_PCI_MSI. When that
> happens, the kernel fails to build with
>
> arch/powerpc/platforms/built-in.o: In function `.xics_startup':
> xics.c:(.text+0x12f60): undefined reference to `.unmask_msi_irq'
> make: *** [.tmp_vmlinux1] Error 1
>
> This patch adds the dependency in KConfig.
Actually we should ifdef the code instead, XICS doesn't require MSI -
that code chunk just needs to be conditional.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <michael@ellerman.id.au>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] powerpc: Add Kconfig dependency for PCI_MSI as needed by XICS
Date: Tue, 17 Nov 2009 23:40:10 +1100 [thread overview]
Message-ID: <1258461610.24093.74.camel@concordia> (raw)
In-Reply-To: <1258459659-11770-2-git-send-email-mel@csn.ul.ie>
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
On Tue, 2009-11-17 at 12:07 +0000, Mel Gorman wrote:
> It's possible to set CONFIG_XICS without CONFIG_PCI_MSI. When that
> happens, the kernel fails to build with
>
> arch/powerpc/platforms/built-in.o: In function `.xics_startup':
> xics.c:(.text+0x12f60): undefined reference to `.unmask_msi_irq'
> make: *** [.tmp_vmlinux1] Error 1
>
> This patch adds the dependency in KConfig.
Actually we should ifdef the code instead, XICS doesn't require MSI -
that code chunk just needs to be conditional.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-11-17 12:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 12:07 [PATCH 0/4] powerpc: Fix minor build issues on 2.6.32-rc7 without CONFIG_XICS set Mel Gorman
2009-11-17 12:07 ` Mel Gorman
2009-11-17 12:07 ` [PATCH 1/4] powerpc: Add Kconfig dependency for PCI_MSI as needed by XICS Mel Gorman
2009-11-17 12:07 ` Mel Gorman
2009-11-17 12:40 ` Michael Ellerman [this message]
2009-11-17 12:40 ` Michael Ellerman
2009-11-17 12:07 ` [PATCH 2/4] powerpc: Panic on platform ppc-xicp when CONFIG_XICS not set instead of build failure Mel Gorman
2009-11-17 12:07 ` Mel Gorman
2009-11-17 12:45 ` Michael Ellerman
2009-11-17 12:45 ` Michael Ellerman
2009-11-17 12:07 ` [PATCH 3/4] powerpc: Only define smp_pSeries_cpu_bootable when CONFIG_XICS is set Mel Gorman
2009-11-17 12:07 ` Mel Gorman
2009-11-17 12:47 ` Michael Ellerman
2009-11-17 12:47 ` Michael Ellerman
2009-11-17 12:07 ` [PATCH 4/4] powerpc: Avoid reference to XICS-related functions when CONFIG_XICS is not set Mel Gorman
2009-11-17 12:07 ` Mel Gorman
2009-11-17 12:39 ` [PATCH 0/4] powerpc: Fix minor build issues on 2.6.32-rc7 without CONFIG_XICS set Michael Ellerman
2009-11-17 12:39 ` Michael Ellerman
2009-11-17 12:52 ` Michael Ellerman
2009-11-17 12:52 ` Michael Ellerman
2009-11-18 6:00 ` Benjamin Herrenschmidt
2009-11-17 13:25 ` Mel Gorman
2009-11-17 13:25 ` Mel Gorman
2009-11-18 6:05 ` Benjamin Herrenschmidt
2009-11-18 6:05 ` Benjamin Herrenschmidt
2009-11-18 17:05 ` Mel Gorman
2009-11-18 17:05 ` Mel Gorman
2009-11-27 2:40 ` Benjamin Herrenschmidt
2009-11-27 2:40 ` Benjamin Herrenschmidt
2009-11-27 16:33 ` [PATCH] powerpc: Add Kconfig dependency on PCI_MSI for XICS and select for PSERIES Mel Gorman
2009-11-27 16:33 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258461610.24093.74.camel@concordia \
--to=michael@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.