All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Michael Buesch <mb@bu3sch.de>, netdev <netdev@vger.kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Felix Fietkau <nbd@openwrt.org>
Subject: Re: [RFC] mac80211: disallow bridging managed/adhoc interfaces
Date: Tue, 17 Nov 2009 12:41:08 -0800	[thread overview]
Message-ID: <1258490468.4447.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20091117090420.0434edc3@nehalam>

On Tue, 2009-11-17 at 09:04 -0800, Stephen Hemminger wrote:
> On Tue, 17 Nov 2009 17:43:43 +0100
> Johannes Berg <johannes@sipsolutions.net> wrote:
> 
> > On Tue, 2009-11-17 at 08:37 -0800, Stephen Hemminger wrote:
> > 
> > > But there are people bridging wireless, and hostap even has a mode for
> > > that. 
> > 
> > But that's the AP side, which this patch doesn't attempt to prevent. It
> > just makes no sense to bridge when connected to an AP or part of an
> > IBSS.
> > 
> 
> Then how does this work now? And will your change break it?
> 
>                              kvm1
>                             /
>      ====> wlan0  --- bridge-- kvm2
>                             \
>                              kvm3

Are you sure 'bridge' isn't NAT-ed to wlan0 like libvirt/etc do by
default?  That's about the only way it can possibly work correctly with
wifi.

Dan



WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
	netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Felix Fietkau <nbd-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>
Subject: Re: [RFC] mac80211: disallow bridging managed/adhoc interfaces
Date: Tue, 17 Nov 2009 12:41:08 -0800	[thread overview]
Message-ID: <1258490468.4447.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20091117090420.0434edc3@nehalam>

On Tue, 2009-11-17 at 09:04 -0800, Stephen Hemminger wrote:
> On Tue, 17 Nov 2009 17:43:43 +0100
> Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> 
> > On Tue, 2009-11-17 at 08:37 -0800, Stephen Hemminger wrote:
> > 
> > > But there are people bridging wireless, and hostap even has a mode for
> > > that. 
> > 
> > But that's the AP side, which this patch doesn't attempt to prevent. It
> > just makes no sense to bridge when connected to an AP or part of an
> > IBSS.
> > 
> 
> Then how does this work now? And will your change break it?
> 
>                              kvm1
>                             /
>      ====> wlan0  --- bridge-- kvm2
>                             \
>                              kvm3

Are you sure 'bridge' isn't NAT-ed to wlan0 like libvirt/etc do by
default?  That's about the only way it can possibly work correctly with
wifi.

Dan


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-11-17 20:41 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 13:46 [RFC] mac80211: disallow bridging managed/adhoc interfaces Johannes Berg
2009-11-17 13:46 ` Johannes Berg
2009-11-17 13:58 ` John W. Linville
2009-11-17 13:58   ` John W. Linville
2009-11-17 14:04   ` Johannes Berg
2009-11-17 14:04 ` Michael Buesch
2009-11-17 14:06   ` John W. Linville
2009-11-17 14:06     ` John W. Linville
2009-11-17 14:07   ` Johannes Berg
2009-11-17 14:07     ` Johannes Berg
2009-11-17 16:37     ` Stephen Hemminger
2009-11-17 16:37       ` Stephen Hemminger
2009-11-17 16:43       ` Johannes Berg
2009-11-17 16:43         ` Johannes Berg
2009-11-17 17:04         ` Stephen Hemminger
2009-11-17 17:04           ` Stephen Hemminger
2009-11-17 17:05           ` Johannes Berg
2009-11-17 20:41           ` Dan Williams [this message]
2009-11-17 20:41             ` Dan Williams
2009-11-17 20:48 ` [RFC v2] " Johannes Berg
2009-11-17 22:42   ` Julian Calaby
2009-11-17 22:42     ` Julian Calaby
2009-11-17 22:46     ` Johannes Berg
2009-11-17 22:50       ` Julian Calaby
2009-11-17 22:42   ` Stephen Hemminger
2009-11-17 22:45     ` Johannes Berg
2009-11-18  1:59   ` Stefan Monnier
2009-11-18  1:59     ` Stefan Monnier
2009-11-18  2:59     ` John W. Linville
2009-11-18  2:59       ` John W. Linville
2009-11-18 10:52       ` Johannes Berg
2009-11-18 10:52         ` Johannes Berg
2009-12-11 12:39 ` [RFC] " Markus Baier
2009-12-11 13:00   ` Johannes Berg
2009-12-11 13:18     ` Markus Baier
2009-12-11 13:58       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258490468.4447.23.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.