* [PATCH 2/2] Adding kerneldoc entry for radio type GPS
@ 2009-11-18 15:22 janakiram.sistla
2009-11-18 15:35 ` Marcel Holtmann
0 siblings, 1 reply; 8+ messages in thread
From: janakiram.sistla @ 2009-11-18 15:22 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Janakiram Sistla
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/rfkill.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index d787d5f..212f555 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -36,6 +36,7 @@
* @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
* @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
* @RFKILL_TYPE_FM: switch is on a FM device.
+ * @RFKILL_TYPE_GPS: switch is on a GPS device.
* @NUM_RFKILL_TYPES: number of defined rfkill types
*/
enum rfkill_type {
--
1.5.4.3
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
2009-11-18 15:22 [PATCH 2/2] Adding kerneldoc entry for radio type GPS janakiram.sistla
@ 2009-11-18 15:35 ` Marcel Holtmann
2009-11-18 15:55 ` Janakiram Sistla
0 siblings, 1 reply; 8+ messages in thread
From: Marcel Holtmann @ 2009-11-18 15:35 UTC (permalink / raw)
To: janakiram.sistla; +Cc: linville, linux-wireless
Hi guys,
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
>
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
> include/linux/rfkill.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index d787d5f..212f555 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -36,6 +36,7 @@
> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> * @RFKILL_TYPE_FM: switch is on a FM device.
> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
> * @NUM_RFKILL_TYPES: number of defined rfkill types
> */
> enum rfkill_type {
so this is getting stupid right now. I am sick of a really simple patch
causes so much trouble. Even this one is wrong again. The GPS doc should
obviously before FM.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
2009-11-18 15:35 ` Marcel Holtmann
@ 2009-11-18 15:55 ` Janakiram Sistla
2009-11-18 16:05 ` Marcel Holtmann
0 siblings, 1 reply; 8+ messages in thread
From: Janakiram Sistla @ 2009-11-18 15:55 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linville, linux-wireless
On Wed, Nov 18, 2009 at 9:05 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi guys,
>
>> From: Janakiram Sistla <janakiram.sistla@gmail.com>
>>
>>
>> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
>> ---
>> include/linux/rfkill.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> index d787d5f..212f555 100644
>> --- a/include/linux/rfkill.h
>> +++ b/include/linux/rfkill.h
>> @@ -36,6 +36,7 @@
>> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> * @RFKILL_TYPE_FM: switch is on a FM device.
>> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> * @NUM_RFKILL_TYPES: number of defined rfkill types
>> */
>> enum rfkill_type {
>
> so this is getting stupid right now. I am sick of a really simple patch
> causes so much trouble. Even this one is wrong again. The GPS doc should
> obviously before FM.
Marcel I think you want me to submit GPS doc patch first.I will be
doing it shortly and then i will do it for FM.I am sorry for this mis
understanding
>
> Regards
>
> Marcel
>
>
>
Regards,
Ram.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
2009-11-18 15:55 ` Janakiram Sistla
@ 2009-11-18 16:05 ` Marcel Holtmann
2009-11-18 16:22 ` Janakiram Sistla
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Marcel Holtmann @ 2009-11-18 16:05 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: linville, linux-wireless
Hi Janakiram,
> >>
> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> >> index d787d5f..212f555 100644
> >> --- a/include/linux/rfkill.h
> >> +++ b/include/linux/rfkill.h
> >> @@ -36,6 +36,7 @@
> >> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
> >> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
> >> * @RFKILL_TYPE_FM: switch is on a FM device.
> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
> >> * @NUM_RFKILL_TYPES: number of defined rfkill types
> >> */
> >> enum rfkill_type {
> >
> > so this is getting stupid right now. I am sick of a really simple patch
> > causes so much trouble. Even this one is wrong again. The GPS doc should
> > obviously before FM.
> Marcel I think you want me to submit GPS doc patch first.I will be
> doing it shortly and then i will do it for FM.I am sorry for this mis
> understanding
I don't care in which order you submit the patches, but the order of the
documentation should match the order in the enum. That is not a strict
requirement, but here it makes total sense to do so.
Also don't worry with the patches anymore. This took way too much ping
pong to get it right, that I just wrote them by myself and submitted
them for inclusion.
Regards
Marcel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
2009-11-18 16:05 ` Marcel Holtmann
@ 2009-11-18 16:22 ` Janakiram Sistla
2009-11-18 17:04 ` Janakiram Sistla
2009-11-18 17:26 ` Janakiram Sistla
2 siblings, 0 replies; 8+ messages in thread
From: Janakiram Sistla @ 2009-11-18 16:22 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linville, linux-wireless
On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >> * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >> * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >> */
>> >> enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.
Hope you can loop me in for the same.So that i can use that patch.
>
> Regards
>
> Marcel
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
2009-11-18 16:05 ` Marcel Holtmann
2009-11-18 16:22 ` Janakiram Sistla
@ 2009-11-18 17:04 ` Janakiram Sistla
2009-11-18 17:26 ` Janakiram Sistla
2 siblings, 0 replies; 8+ messages in thread
From: Janakiram Sistla @ 2009-11-18 17:04 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linville, linux-wireless
On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >> * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >> * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >> */
>> >> enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.
>
> Regards
>
> Marcel
>
>
>
I hope in that case i think it should be give signed off by both for
both the patches.
Regards,
Ram
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] Adding kerneldoc entry for radio type GPS
2009-11-18 16:05 ` Marcel Holtmann
2009-11-18 16:22 ` Janakiram Sistla
2009-11-18 17:04 ` Janakiram Sistla
@ 2009-11-18 17:26 ` Janakiram Sistla
2 siblings, 0 replies; 8+ messages in thread
From: Janakiram Sistla @ 2009-11-18 17:26 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linville, linux-wireless
On Wed, Nov 18, 2009 at 9:35 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> >>
>> >> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> >> index d787d5f..212f555 100644
>> >> --- a/include/linux/rfkill.h
>> >> +++ b/include/linux/rfkill.h
>> >> @@ -36,6 +36,7 @@
>> >> * @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
>> >> * @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
>> >> * @RFKILL_TYPE_FM: switch is on a FM device.
>> >> + * @RFKILL_TYPE_GPS: switch is on a GPS device.
>> >> * @NUM_RFKILL_TYPES: number of defined rfkill types
>> >> */
>> >> enum rfkill_type {
>> >
>> > so this is getting stupid right now. I am sick of a really simple patch
>> > causes so much trouble. Even this one is wrong again. The GPS doc should
>> > obviously before FM.
>> Marcel I think you want me to submit GPS doc patch first.I will be
>> doing it shortly and then i will do it for FM.I am sorry for this mis
>> understanding
>
> I don't care in which order you submit the patches, but the order of the
> documentation should match the order in the enum. That is not a strict
> requirement, but here it makes total sense to do so.
>
> Also don't worry with the patches anymore. This took way too much ping
> pong to get it right, that I just wrote them by myself and submitted
> them for inclusion.
I hope in that case i think it should be give signed off by both authors for
both the patches.
> Regards
>
> Marcel
>
>
>
Regards,
Ram.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] Adding kerneldoc entry for radio type GPS
@ 2009-11-18 15:56 janakiram.sistla
0 siblings, 0 replies; 8+ messages in thread
From: janakiram.sistla @ 2009-11-18 15:56 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Janakiram Sistla
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Adding kerneldoc entry for radio type GPS
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/rfkill.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index d787d5f..212f555 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -36,6 +36,7 @@
* @RFKILL_TYPE_WIMAX: switch is on a WiMAX device.
* @RFKILL_TYPE_WWAN: switch is on a wireless WAN device.
* @RFKILL_TYPE_FM: switch is on a FM device.
+ * @RFKILL_TYPE_GPS: switch is on a GPS device.
* @NUM_RFKILL_TYPES: number of defined rfkill types
*/
enum rfkill_type {
--
1.5.4.3
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-11-18 17:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-18 15:22 [PATCH 2/2] Adding kerneldoc entry for radio type GPS janakiram.sistla
2009-11-18 15:35 ` Marcel Holtmann
2009-11-18 15:55 ` Janakiram Sistla
2009-11-18 16:05 ` Marcel Holtmann
2009-11-18 16:22 ` Janakiram Sistla
2009-11-18 17:04 ` Janakiram Sistla
2009-11-18 17:26 ` Janakiram Sistla
-- strict thread matches above, loose matches on Subject: below --
2009-11-18 15:56 janakiram.sistla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.