All of lore.kernel.org
 help / color / mirror / Atom feed
* Mute lfe and side for 4930g when pluging in headphones
@ 2009-11-19 22:39 Łukasz Wojniłowicz
  2009-11-20  7:52 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Łukasz Wojniłowicz @ 2009-11-19 22:39 UTC (permalink / raw)
  To: patch; +Cc: alsa-devel

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

Sorry that I'm not sending this patch by git but it takes for me too
long to clone alsa-kernel.git repository at 15 KB download rate. Thanks
for your understanding

[-- Attachment #2: 4930g mute lfe and side.patch --]
[-- Type: text/x-patch, Size: 768 bytes --]

From: =?utf-8?q?=C5=81ukasz=20Wojni=C5=82owicz?= <lukasz.wojnilowicz@gmail.com>
Subject: Mute lfe and side for 4930g when pluging in headphones
Comment: Fixes first issue from comment 0021423 in bug from site https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4317

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index eee3143..4ed3b77 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -1786,6 +1786,8 @@ static void alc888_acer_aspire_4930g_setup(struct hda_codec *codec)
 
 	spec->autocfg.hp_pins[0] = 0x15;
 	spec->autocfg.speaker_pins[0] = 0x14;
+	spec->autocfg.speaker_pins[1] = 0x16;
+	spec->autocfg.speaker_pins[2] = 0x17;
 }
 
 static void alc888_acer_aspire_6530g_setup(struct hda_codec *codec)

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: Mute lfe and side for 4930g when pluging in headphones
  2009-11-19 22:39 Mute lfe and side for 4930g when pluging in headphones Łukasz Wojniłowicz
@ 2009-11-20  7:52 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-11-20  7:52 UTC (permalink / raw)
  To: Łukasz Wojniłowicz; +Cc: alsa-devel

At Thu, 19 Nov 2009 23:39:17 +0100,
Łukasz Wojniłowicz wrote:
> 
> Sorry that I'm not sending this patch by git but it takes for me too
> long to clone alsa-kernel.git repository at 15 KB download rate. Thanks
> for your understanding

It's fine to send a patch as a mail.  It's rather preferred in normal
cases.

But, it'd be helpful if you reformat the patch to be applicable directly
via git am.  And, above all, don't forget your sign-off.  Otherwise
we can't merge the patch.

The changes look OK to me.  Could you repost with the above?


Thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-20  7:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19 22:39 Mute lfe and side for 4930g when pluging in headphones Łukasz Wojniłowicz
2009-11-20  7:52 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.