From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, pbonzini@redhat.com,
kwolf@redhat.com, hreitz@redhat.com, imp@bsdimp.com,
kevans@freebsd.org, berrange@redhat.com, groug@kaod.org,
mst@redhat.com, philmd@linaro.org, peter.maydell@linaro.org,
alistair@alistair23.me, jasowang@redhat.com,
jonathan.cameron@huawei.com, kbastian@mail.uni-paderborn.de,
quintela@redhat.com, dgilbert@redhat.com, michael.roth@amd.com,
kkostiuk@redhat.com, tsimpson@quicinc.com, palmer@dabbelt.com,
bin.meng@windriver.com, qemu-block@nongnu.org,
qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h
Date: Thu, 19 Jan 2023 13:06:26 +0100 [thread overview]
Message-ID: <12588900.kcvoAOTtsJ@silver> (raw)
In-Reply-To: <20230119065959.3104012-18-armbru@redhat.com>
On Thursday, January 19, 2023 7:59:57 AM CET Markus Armbruster wrote:
> This commit was created with scripts/clean-includes.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
For 9p changes:
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> backends/tpm/tpm_ioctl.h | 2 --
> fsdev/p9array.h | 2 --
> include/hw/misc/aspeed_lpc.h | 2 --
> include/hw/pci/pcie_doe.h | 1 -
> include/qemu/async-teardown.h | 2 --
> include/qemu/dbus.h | 1 -
> include/qemu/host-utils.h | 1 -
> include/sysemu/event-loop-base.h | 1 -
> accel/tcg/cpu-exec.c | 1 -
> hw/9pfs/9p.c | 2 --
> hw/display/virtio-gpu-udmabuf.c | 1 -
> hw/i2c/pmbus_device.c | 1 -
> hw/remote/proxy-memory-listener.c | 1 -
> hw/sensor/adm1272.c | 1 -
> hw/usb/dev-storage-bot.c | 1 -
> hw/usb/dev-storage-classic.c | 1 -
> softmmu/vl.c | 2 --
> tcg/tci.c | 1 -
> tests/unit/test-seccomp.c | 1 -
> ui/udmabuf.c | 1 -
> util/main-loop.c | 1 -
> util/oslib-posix.c | 2 --
> 22 files changed, 29 deletions(-)
>
> diff --git a/backends/tpm/tpm_ioctl.h b/backends/tpm/tpm_ioctl.h
> index e506ef5160..b1d31768a6 100644
> --- a/backends/tpm/tpm_ioctl.h
> +++ b/backends/tpm/tpm_ioctl.h
> @@ -12,8 +12,6 @@
> # define __USE_LINUX_IOCTL_DEFS
> #endif
>
> -#include <stdint.h>
> -#include <sys/types.h>
> #ifndef _WIN32
> #include <sys/uio.h>
> #include <sys/ioctl.h>
> diff --git a/fsdev/p9array.h b/fsdev/p9array.h
> index 90e83a7c7b..50a1b15fe9 100644
> --- a/fsdev/p9array.h
> +++ b/fsdev/p9array.h
> @@ -27,8 +27,6 @@
> #ifndef QEMU_P9ARRAY_H
> #define QEMU_P9ARRAY_H
>
> -#include "qemu/compiler.h"
> -
> /**
> * P9Array provides a mechanism to access arrays in common C-style (e.g. by
> * square bracket [] operator) in conjunction with reference variables that
> diff --git a/include/hw/misc/aspeed_lpc.h b/include/hw/misc/aspeed_lpc.h
> index fd228731d2..fa398959af 100644
> --- a/include/hw/misc/aspeed_lpc.h
> +++ b/include/hw/misc/aspeed_lpc.h
> @@ -12,8 +12,6 @@
>
> #include "hw/sysbus.h"
>
> -#include <stdint.h>
> -
> #define TYPE_ASPEED_LPC "aspeed.lpc"
> #define ASPEED_LPC(obj) OBJECT_CHECK(AspeedLPCState, (obj), TYPE_ASPEED_LPC)
>
> diff --git a/include/hw/pci/pcie_doe.h b/include/hw/pci/pcie_doe.h
> index ba4d8b03bd..87dc17dcef 100644
> --- a/include/hw/pci/pcie_doe.h
> +++ b/include/hw/pci/pcie_doe.h
> @@ -11,7 +11,6 @@
> #define PCIE_DOE_H
>
> #include "qemu/range.h"
> -#include "qemu/typedefs.h"
> #include "hw/register.h"
>
> /*
> diff --git a/include/qemu/async-teardown.h b/include/qemu/async-teardown.h
> index 092e7a37e7..b281da005b 100644
> --- a/include/qemu/async-teardown.h
> +++ b/include/qemu/async-teardown.h
> @@ -13,8 +13,6 @@
> #ifndef QEMU_ASYNC_TEARDOWN_H
> #define QEMU_ASYNC_TEARDOWN_H
>
> -#include "config-host.h"
> -
> #ifdef CONFIG_LINUX
> void init_async_teardown(void);
> #endif
> diff --git a/include/qemu/dbus.h b/include/qemu/dbus.h
> index 08f00dfd53..81d3de8a5a 100644
> --- a/include/qemu/dbus.h
> +++ b/include/qemu/dbus.h
> @@ -15,7 +15,6 @@
> #include "qom/object.h"
> #include "chardev/char.h"
> #include "qemu/notify.h"
> -#include "qemu/typedefs.h"
>
> /* glib/gio 2.68 */
> #define DBUS_METHOD_INVOCATION_HANDLED TRUE
> diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h
> index 88d476161c..3ce62bf4a5 100644
> --- a/include/qemu/host-utils.h
> +++ b/include/qemu/host-utils.h
> @@ -30,7 +30,6 @@
> #ifndef HOST_UTILS_H
> #define HOST_UTILS_H
>
> -#include "qemu/compiler.h"
> #include "qemu/bswap.h"
> #include "qemu/int128.h"
>
> diff --git a/include/sysemu/event-loop-base.h b/include/sysemu/event-loop-base.h
> index 2748bf6ae1..a6c24f1351 100644
> --- a/include/sysemu/event-loop-base.h
> +++ b/include/sysemu/event-loop-base.h
> @@ -14,7 +14,6 @@
>
> #include "qom/object.h"
> #include "block/aio.h"
> -#include "qemu/typedefs.h"
>
> #define TYPE_EVENT_LOOP_BASE "event-loop-base"
> OBJECT_DECLARE_TYPE(EventLoopBase, EventLoopBaseClass,
> diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
> index 8927092537..dd8f54a415 100644
> --- a/accel/tcg/cpu-exec.c
> +++ b/accel/tcg/cpu-exec.c
> @@ -28,7 +28,6 @@
> #include "exec/exec-all.h"
> #include "tcg/tcg.h"
> #include "qemu/atomic.h"
> -#include "qemu/compiler.h"
> #include "qemu/timer.h"
> #include "qemu/rcu.h"
> #include "exec/log.h"
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index 072cf67956..9621ec1341 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -19,8 +19,6 @@
> #include "qemu/osdep.h"
> #ifdef CONFIG_LINUX
> #include <linux/limits.h>
> -#else
> -#include <limits.h>
> #endif
> #include <glib/gprintf.h>
> #include "hw/virtio/virtio.h"
> diff --git a/hw/display/virtio-gpu-udmabuf.c b/hw/display/virtio-gpu-udmabuf.c
> index 8bdf4bac6e..847fa4c0cc 100644
> --- a/hw/display/virtio-gpu-udmabuf.c
> +++ b/hw/display/virtio-gpu-udmabuf.c
> @@ -21,7 +21,6 @@
> #include "exec/ramblock.h"
> #include "sysemu/hostmem.h"
> #include <sys/ioctl.h>
> -#include <fcntl.h>
> #include <linux/memfd.h>
> #include "qemu/memfd.h"
> #include "standard-headers/linux/udmabuf.h"
> diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c
> index 4071a88cfc..c3d6046784 100644
> --- a/hw/i2c/pmbus_device.c
> +++ b/hw/i2c/pmbus_device.c
> @@ -8,7 +8,6 @@
>
> #include "qemu/osdep.h"
> #include <math.h>
> -#include <string.h>
> #include "hw/i2c/pmbus_device.h"
> #include "migration/vmstate.h"
> #include "qemu/module.h"
> diff --git a/hw/remote/proxy-memory-listener.c b/hw/remote/proxy-memory-listener.c
> index eb9918fe72..18d96a1d04 100644
> --- a/hw/remote/proxy-memory-listener.c
> +++ b/hw/remote/proxy-memory-listener.c
> @@ -8,7 +8,6 @@
>
> #include "qemu/osdep.h"
>
> -#include "qemu/compiler.h"
> #include "qemu/int128.h"
> #include "qemu/range.h"
> #include "exec/memory.h"
> diff --git a/hw/sensor/adm1272.c b/hw/sensor/adm1272.c
> index 7310c769be..8f4a1c2cd4 100644
> --- a/hw/sensor/adm1272.c
> +++ b/hw/sensor/adm1272.c
> @@ -8,7 +8,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include <string.h>
> #include "hw/i2c/pmbus_device.h"
> #include "hw/irq.h"
> #include "migration/vmstate.h"
> diff --git a/hw/usb/dev-storage-bot.c b/hw/usb/dev-storage-bot.c
> index b24b3148c2..1e5c5c711f 100644
> --- a/hw/usb/dev-storage-bot.c
> +++ b/hw/usb/dev-storage-bot.c
> @@ -8,7 +8,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/typedefs.h"
> #include "qapi/error.h"
> #include "hw/usb.h"
> #include "hw/usb/desc.h"
> diff --git a/hw/usb/dev-storage-classic.c b/hw/usb/dev-storage-classic.c
> index 00f25bade2..84d19752b5 100644
> --- a/hw/usb/dev-storage-classic.c
> +++ b/hw/usb/dev-storage-classic.c
> @@ -8,7 +8,6 @@
> */
>
> #include "qemu/osdep.h"
> -#include "qemu/typedefs.h"
> #include "qapi/error.h"
> #include "qapi/visitor.h"
> #include "hw/usb.h"
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 9177d95d4e..5355a7fe5a 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -136,8 +136,6 @@
> #include "qemu/guest-random.h"
> #include "qemu/keyval.h"
>
> -#include "config-host.h"
> -
> #define MAX_VIRTIO_CONSOLES 1
>
> typedef struct BlockdevOptionsQueueEntry {
> diff --git a/tcg/tci.c b/tcg/tci.c
> index 05a24163d3..e7ac74cab0 100644
> --- a/tcg/tci.c
> +++ b/tcg/tci.c
> @@ -21,7 +21,6 @@
> #include "exec/cpu_ldst.h"
> #include "tcg/tcg-op.h"
> #include "tcg/tcg-ldst.h"
> -#include "qemu/compiler.h"
> #include <ffi.h>
>
>
> diff --git a/tests/unit/test-seccomp.c b/tests/unit/test-seccomp.c
> index 3d7771e46c..f02c79cafd 100644
> --- a/tests/unit/test-seccomp.c
> +++ b/tests/unit/test-seccomp.c
> @@ -25,7 +25,6 @@
> #include "qapi/error.h"
> #include "qemu/module.h"
>
> -#include <unistd.h>
> #include <sys/syscall.h>
>
> static void test_seccomp_helper(const char *args, bool killed,
> diff --git a/ui/udmabuf.c b/ui/udmabuf.c
> index cebceb2610..cbf4357bb1 100644
> --- a/ui/udmabuf.c
> +++ b/ui/udmabuf.c
> @@ -8,7 +8,6 @@
> #include "qapi/error.h"
> #include "ui/console.h"
>
> -#include <fcntl.h>
> #include <sys/ioctl.h>
>
> int udmabuf_fd(void)
> diff --git a/util/main-loop.c b/util/main-loop.c
> index 58f776a8c9..3c0f525192 100644
> --- a/util/main-loop.c
> +++ b/util/main-loop.c
> @@ -33,7 +33,6 @@
> #include "block/thread-pool.h"
> #include "qemu/error-report.h"
> #include "qemu/queue.h"
> -#include "qemu/compiler.h"
> #include "qom/object.h"
>
> #ifndef _WIN32
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 59a891b6a8..fd03fd32c8 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -40,7 +40,6 @@
> #include "qemu/thread.h"
> #include <libgen.h>
> #include "qemu/cutils.h"
> -#include "qemu/compiler.h"
> #include "qemu/units.h"
> #include "qemu/thread-context.h"
>
> @@ -50,7 +49,6 @@
>
> #ifdef __FreeBSD__
> #include <sys/thr.h>
> -#include <sys/types.h>
> #include <sys/user.h>
> #include <libutil.h>
> #endif
>
next prev parent reply other threads:[~2023-01-19 12:06 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 6:59 [PATCH v4 00/19] Clean up includes Markus Armbruster
2023-01-19 6:59 ` [PATCH v4 01/19] scripts/clean-includes: Fully skip / ignore files Markus Armbruster
2023-01-27 21:29 ` Eric Blake
2023-01-28 10:28 ` Michael S. Tsirkin
2023-01-30 12:55 ` Markus Armbruster
2023-01-19 6:59 ` [PATCH v4 02/19] scripts/clean-includes: Don't claim duplicate headers found when not Markus Armbruster
2023-01-27 21:38 ` Eric Blake
2023-01-19 6:59 ` [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links Markus Armbruster
2023-01-27 22:47 ` Eric Blake
2023-01-27 23:08 ` Warner Losh
2023-01-19 6:59 ` [PATCH v4 04/19] bsd-user: Clean up includes Markus Armbruster
2023-01-19 14:42 ` Warner Losh
2023-01-19 16:42 ` Markus Armbruster
2023-01-19 17:05 ` Warner Losh
2023-01-27 12:01 ` Markus Armbruster
2023-01-27 14:54 ` Peter Maydell
2023-01-27 15:01 ` Michael S. Tsirkin
2023-01-28 10:29 ` Michael S. Tsirkin
2023-01-30 13:12 ` Markus Armbruster
2023-01-19 6:59 ` [PATCH v4 05/19] crypto: " Markus Armbruster
2023-01-19 10:34 ` Philippe Mathieu-Daudé
2023-01-19 6:59 ` [PATCH v4 06/19] hw/cxl: " Markus Armbruster
2023-01-19 6:59 ` [PATCH v4 07/19] hw/input: " Markus Armbruster
2023-01-19 6:59 ` [PATCH v4 08/19] hw/tricore: " Markus Armbruster
2023-01-19 10:34 ` Philippe Mathieu-Daudé
2023-01-19 6:59 ` [PATCH v4 09/19] qga: " Markus Armbruster
2023-01-19 8:30 ` Konstantin Kostiuk
2023-01-19 6:59 ` [PATCH v4 10/19] migration: " Markus Armbruster
2023-01-19 9:34 ` Dr. David Alan Gilbert
2023-01-19 10:31 ` Markus Armbruster
2023-01-19 11:45 ` Dr. David Alan Gilbert
2023-01-20 7:19 ` Markus Armbruster
2023-01-30 4:11 ` Juan Quintela
2023-01-19 6:59 ` [PATCH v4 11/19] net: " Markus Armbruster
2023-01-19 10:35 ` Philippe Mathieu-Daudé
2023-01-19 6:59 ` [PATCH v4 12/19] target/hexagon: " Markus Armbruster
2023-01-19 22:15 ` Taylor Simpson
2023-01-20 7:21 ` Markus Armbruster
2023-01-19 6:59 ` [PATCH v4 13/19] riscv: " Markus Armbruster
2023-01-19 10:38 ` Philippe Mathieu-Daudé
2023-01-19 22:44 ` Alistair Francis
2023-01-19 6:59 ` [PATCH v4 14/19] block: " Markus Armbruster
2023-01-27 22:55 ` Eric Blake
2023-01-19 6:59 ` [PATCH v4 15/19] accel: " Markus Armbruster
2023-01-19 10:36 ` Philippe Mathieu-Daudé
2023-01-19 6:59 ` [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h Markus Armbruster
2023-01-19 10:40 ` Philippe Mathieu-Daudé
2023-01-19 11:41 ` Markus Armbruster
2023-01-19 11:52 ` Philippe Mathieu-Daudé
2023-01-19 12:40 ` Markus Armbruster
2023-01-27 12:05 ` Markus Armbruster
2023-01-30 4:13 ` Juan Quintela
2023-01-19 6:59 ` [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h Markus Armbruster
2023-01-19 12:06 ` Christian Schoenebeck [this message]
2023-01-19 6:59 ` [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h Markus Armbruster
2023-01-19 9:50 ` Christian Schoenebeck
2023-01-19 10:37 ` Markus Armbruster
2023-01-19 12:01 ` Christian Schoenebeck
2023-01-19 6:59 ` [PATCH v4 19/19] Drop duplicate #include Markus Armbruster
2023-01-19 10:19 ` Dr. David Alan Gilbert
2023-01-19 14:17 ` Greg Kurz
2023-01-30 4:16 ` Juan Quintela
2023-01-19 9:20 ` [PATCH v4 00/19] Clean up includes Markus Armbruster
2023-01-19 11:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12588900.kcvoAOTtsJ@silver \
--to=qemu_oss@crudebyte.com \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=hreitz@redhat.com \
--cc=imp@bsdimp.com \
--cc=jasowang@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kevans@freebsd.org \
--cc=kkostiuk@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.