Re: [PATCH] enable erase-suspend-program for CFI cmdset_0002

[Artem Bityutskiy <dedekind1@gmail.com>]

On Tue, 2009-11-24 at 10:07 +0100, Norbert van Bolhuis wrote:
> Nicolas Pitre wrote:
> > On Thu, 19 Nov 2009, Norbert van Bolhuis wrote:
> > 
> >> erase-suspend for writing is required to avoid blocking applications that wish
> >> to write some data (to a NOR block other than the one being erased).
> >> Particularly, it solves some huge delays that an application (which writes to a
> >> UBIFS) will experience if UBI attaches to empty NOR flash. In this case the
> >> UBI background thread will erase a lot of blocks and the application can be blocked
> >> for minutes because of the "MTD/CFI chip lock".
> >> This feature has been disabled for years. Maybe this was because the old code
> >> turned it on for erase-suspend read-only chips also (cfip->EraseSuspend & 0x1).
> >> This is wrong and corrected now.
> >> I tested this patch and it seems to work fine.
> >>
> >> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
> > 
> > FYI: I have no experience with non-Intel parts and no good knowledge of 
> > the cmdset_0002 code.  So I can't review this.
> > 
> 
> OK.
> 
> so, who's approving/reviewing patches for cmdset_0002. Nobody ?

I think we can just take it, since you tested it and confirm it works
and solves a real problem. I'll put it to my l2 tree later, do not have
time right now.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)