All of lore.kernel.org
 help / color / mirror / Atom feed
From: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] enable erase-suspend-program for CFI cmdset_0002
Date: Tue, 24 Nov 2009 10:07:59 +0100	[thread overview]
Message-ID: <4B0BA26F.2020707@aimvalley.nl> (raw)
In-Reply-To: <alpine.LFD.2.00.0911221243070.2059@xanadu.home>


Nicolas Pitre wrote:
> On Thu, 19 Nov 2009, Norbert van Bolhuis wrote:
> 
>> erase-suspend for writing is required to avoid blocking applications that wish
>> to write some data (to a NOR block other than the one being erased).
>> Particularly, it solves some huge delays that an application (which writes to a
>> UBIFS) will experience if UBI attaches to empty NOR flash. In this case the
>> UBI background thread will erase a lot of blocks and the application can be blocked
>> for minutes because of the "MTD/CFI chip lock".
>> This feature has been disabled for years. Maybe this was because the old code
>> turned it on for erase-suspend read-only chips also (cfip->EraseSuspend & 0x1).
>> This is wrong and corrected now.
>> I tested this patch and it seems to work fine.
>>
>> Signed-off-by: Norbert van Bolhuis <nvbolhuis@aimvalley.nl>
> 
> FYI: I have no experience with non-Intel parts and no good knowledge of 
> the cmdset_0002 code.  So I can't review this.
> 

OK.

so, who's approving/reviewing patches for cmdset_0002. Nobody ?

  reply	other threads:[~2009-11-24  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-19 11:01 [PATCH] enable erase-suspend-program for CFI cmdset_0002 Norbert van Bolhuis
2009-11-22 17:45 ` Nicolas Pitre
2009-11-24  9:07   ` Norbert van Bolhuis [this message]
2009-11-24  9:42     ` Artem Bityutskiy
2009-11-24 14:36 ` Artem Bityutskiy
2009-11-24 15:12   ` Norbert van Bolhuis
2009-11-24 15:15     ` Artem Bityutskiy
2009-11-24 15:20       ` Norbert van Bolhuis
2009-11-24 15:26         ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B0BA26F.2020707@aimvalley.nl \
    --to=nvbolhuis@aimvalley.nl \
    --cc=linux-mtd@lists.infradead.org \
    --cc=nico@fluxnic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.