From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] JFFS2: min/max confusion?
Date: Thu, 26 Nov 2009 09:05:25 +0200 [thread overview]
Message-ID: <1259219125.29118.41.camel@localhost> (raw)
In-Reply-To: <4B08088C.8050305@gmail.com>
On Sat, 2009-11-21 at 16:34 +0100, Roel Kluin wrote:
> MAX_SUMMARY_SIZE was meant as a limit, not as a minimum
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> fs/jffs2/summary.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> unless I am mistaken?
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index 6caf1e1..800171d 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -23,7 +23,7 @@
>
> int jffs2_sum_init(struct jffs2_sb_info *c)
> {
> - uint32_t sum_size = max_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
> + uint32_t sum_size = min_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
>
> c->summary = kzalloc(sizeof(struct jffs2_summary), GFP_KERNEL);
This looks right, I've pushed your patch to my l2-mtd tree, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] JFFS2: min/max confusion?
Date: Thu, 26 Nov 2009 09:05:25 +0200 [thread overview]
Message-ID: <1259219125.29118.41.camel@localhost> (raw)
In-Reply-To: <4B08088C.8050305@gmail.com>
On Sat, 2009-11-21 at 16:34 +0100, Roel Kluin wrote:
> MAX_SUMMARY_SIZE was meant as a limit, not as a minimum
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> fs/jffs2/summary.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> unless I am mistaken?
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index 6caf1e1..800171d 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -23,7 +23,7 @@
>
> int jffs2_sum_init(struct jffs2_sb_info *c)
> {
> - uint32_t sum_size = max_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
> + uint32_t sum_size = min_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
>
> c->summary = kzalloc(sizeof(struct jffs2_summary), GFP_KERNEL);
This looks right, I've pushed your patch to my l2-mtd tree, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2009-11-26 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 15:34 [PATCH] JFFS2: min/max confusion? Roel Kluin
2009-11-26 7:05 ` Artem Bityutskiy [this message]
2009-11-26 7:05 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259219125.29118.41.camel@localhost \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.