From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Jeremy, Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
Yu Ke <ke.yu@intel.com>
Subject: Re: [PATCH] xen: allow CONFIG_ACPI_PROCESSOR_XEN=m
Date: Thu, 3 Dec 2009 22:46:02 +0000 [thread overview]
Message-ID: <1259880362.31045.154.camel@localhost.localdomain> (raw)
In-Reply-To: <4B183E8F.6040601@goop.org>
On Thu, 2009-12-03 at 22:41 +0000, Jeremy Fitzhardinge wrote:
> On 12/03/09 14:03, Ian Campbell wrote:
> > diff --git a/include/xen/acpi.h b/include/xen/acpi.h
> > index 3d7ea40..8506688 100644
> > --- a/include/xen/acpi.h
> > +++ b/include/xen/acpi.h
> > @@ -41,7 +41,7 @@ int acpi_notify_hypervisor_state(u8 sleep_state,
> > #define HOTPLUG_TYPE_ADD 0
> > #define HOTPLUG_TYPE_REMOVE 1
> >
> > -#ifdef CONFIG_ACPI_PROCESSOR_XEN
> > +#if defined(CONFIG_ACPI_PROCESSOR_XEN) || defined(CONFIG_ACPI_PROCESSOR_XEN_MODULE)
> >
>
> Is this necessary? I thought =m defined CONFIG_ACPI_PROCESSOR_XE.
I thought so too but I got a build error without this change:
CC [M] drivers/xen/acpi_processor.o
drivers/xen/acpi_processor.c:41: error: variable ‘xen_ops’ has initializer but incomplete type
drivers/xen/acpi_processor.c:42: error: unknown field ‘hotplug’ specified in initializer
drivers/xen/acpi_processor.c:42: warning: excess elements in struct initializer
drivers/xen/acpi_processor.c:42: warning: (near initialization for ‘xen_ops’)
drivers/xen/acpi_processor.c:47: error: redefinition of ‘processor_cntl_xen_power_cache’
include/xen/acpi.h:74: error: previous definition of ‘processor_cntl_xen_power_cache’ was here
drivers/xen/acpi_processor.c:72: error: redefinition of ‘processor_cntl_xen’
include/xen/acpi.h:63: error: previous definition of ‘processor_cntl_xen’ was here
drivers/xen/acpi_processor.c:78: error: redefinition of ‘processor_cntl_xen_pm’
include/xen/acpi.h:64: error: previous definition of ‘processor_cntl_xen_pm’ was here
drivers/xen/acpi_processor.c: In function ‘processor_cntl_xen_pm’:
drivers/xen/acpi_processor.c:80: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c: At top level:
drivers/xen/acpi_processor.c:84: error: redefinition of ‘processor_cntl_xen_pmperf’
include/xen/acpi.h:65: error: previous definition of ‘processor_cntl_xen_pmperf’ was here
drivers/xen/acpi_processor.c: In function ‘processor_cntl_xen_pmperf’:
drivers/xen/acpi_processor.c:86: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c: At top level:
drivers/xen/acpi_processor.c:90: error: redefinition of ‘processor_cntl_xen_pmthr’
include/xen/acpi.h:66: error: previous definition of ‘processor_cntl_xen_pmthr’ was here
drivers/xen/acpi_processor.c: In function ‘processor_cntl_xen_pmthr’:
drivers/xen/acpi_processor.c:92: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c: At top level:
drivers/xen/acpi_processor.c:96: error: redefinition of ‘processor_cntl_xen_notify’
include/xen/acpi.h:69: error: previous definition of ‘processor_cntl_xen_notify’ was here
drivers/xen/acpi_processor.c: In function ‘processor_cntl_xen_notify’:
drivers/xen/acpi_processor.c:104: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c:107: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c:110: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c:111: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c: In function ‘xen_acpi_processor_extcntl_init’:
drivers/xen/acpi_processor.c:327: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c:329: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
drivers/xen/acpi_processor.c:331: error: invalid use of undefined type ‘struct processor_cntl_xen_ops’
make[2]: *** [drivers/xen/acpi_processor.o] Error 1
make[1]: *** [drivers/xen/] Error 2
make: *** [sub-make] Error 2
Ian.
prev parent reply other threads:[~2009-12-03 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 22:03 [PATCH] xen: allow CONFIG_ACPI_PROCESSOR_XEN=m Ian Campbell
2009-12-03 22:41 ` Jeremy Fitzhardinge
2009-12-03 22:46 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259880362.31045.154.camel@localhost.localdomain \
--to=ian.campbell@citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=ke.yu@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.