From: Brian Gerst <brgerst@gmail.com>
To: hpa@zytor.com
Cc: Ingo Molnar <mingo@elte.hu>,
x86@kernel.org, torvalds@linux-foundation.org, jeremy@goop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/6] x86: Merge sys_iopl
Date: Wed, 9 Dec 2009 19:01:52 -0500 [thread overview]
Message-ID: <1260403316-5679-3-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1260403316-5679-1-git-send-email-brgerst@gmail.com>
Change 32-bit sys_iopl to PTREGSCALL1, and merge with 64-bit.
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/include/asm/syscalls.h | 6 +-----
arch/x86/kernel/entry_32.S | 2 +-
arch/x86/kernel/ioport.c | 28 +++++-----------------------
3 files changed, 7 insertions(+), 29 deletions(-)
diff --git a/arch/x86/include/asm/syscalls.h b/arch/x86/include/asm/syscalls.h
index 372b76e..4b694cd 100644
--- a/arch/x86/include/asm/syscalls.h
+++ b/arch/x86/include/asm/syscalls.h
@@ -18,6 +18,7 @@
/* Common in X86_32 and X86_64 */
/* kernel/ioport.c */
asmlinkage long sys_ioperm(unsigned long, unsigned long, int);
+long sys_iopl(unsigned int, struct pt_regs *);
/* kernel/process.c */
int sys_fork(struct pt_regs *);
@@ -35,8 +36,6 @@ asmlinkage int sys_get_thread_area(struct user_desc __user *);
/* X86_32 only */
#ifdef CONFIG_X86_32
-/* kernel/ioport.c */
-long sys_iopl(struct pt_regs *);
/* kernel/process_32.c */
int sys_clone(struct pt_regs *);
@@ -70,9 +69,6 @@ int sys_vm86(struct pt_regs *);
#else /* CONFIG_X86_32 */
/* X86_64 only */
-/* kernel/ioport.c */
-asmlinkage long sys_iopl(unsigned int, struct pt_regs *);
-
/* kernel/process_64.c */
asmlinkage long sys_clone(unsigned long, unsigned long,
void __user *, void __user *,
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 34dbfa9..ab7fcef 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -758,7 +758,7 @@ ptregs_##name: \
addl $4,%esp; \
ret
-PTREGSCALL0(iopl)
+PTREGSCALL1(iopl)
PTREGSCALL0(fork)
PTREGSCALL0(clone)
PTREGSCALL0(vfork)
diff --git a/arch/x86/kernel/ioport.c b/arch/x86/kernel/ioport.c
index 99c4d30..85ecc7c 100644
--- a/arch/x86/kernel/ioport.c
+++ b/arch/x86/kernel/ioport.c
@@ -103,9 +103,10 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on)
* on system-call entry - see also fork() and the signal handling
* code.
*/
-static int do_iopl(unsigned int level, struct pt_regs *regs)
+long sys_iopl(unsigned int level, struct pt_regs *regs)
{
unsigned int old = (regs->flags >> 12) & 3;
+ struct thread_struct *t = ¤t->thread;
if (level > 3)
return -EINVAL;
@@ -115,29 +116,10 @@ static int do_iopl(unsigned int level, struct pt_regs *regs)
return -EPERM;
}
regs->flags = (regs->flags & ~X86_EFLAGS_IOPL) | (level << 12);
-
- return 0;
-}
-
#ifdef CONFIG_X86_32
-long sys_iopl(struct pt_regs *regs)
-{
- unsigned int level = regs->bx;
- struct thread_struct *t = ¤t->thread;
- int rc;
-
- rc = do_iopl(level, regs);
- if (rc < 0)
- goto out;
-
t->iopl = level << 12;
set_iopl_mask(t->iopl);
-out:
- return rc;
-}
-#else
-asmlinkage long sys_iopl(unsigned int level, struct pt_regs *regs)
-{
- return do_iopl(level, regs);
-}
#endif
+
+ return 0;
+}
--
1.6.5.2
next prev parent reply other threads:[~2009-12-10 0:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 0:01 [PATCH 0/6] x86: Merge pt_regs using syscalls Brian Gerst
2009-12-10 0:01 ` [PATCH 1/6] x86, 32-bit: Add new pt_regs stubs Brian Gerst
2009-12-10 0:05 ` H. Peter Anvin
2009-12-10 0:45 ` [tip:x86/asm] x86-32: " tip-bot for Brian Gerst
2009-12-10 0:47 ` [tip:x86/asm] x86-32: Avoid pipeline serialization in PTREGSCALL1 and 2 tip-bot for H. Peter Anvin
2009-12-10 0:01 ` Brian Gerst [this message]
2009-12-10 0:45 ` [tip:x86/asm] x86: Merge sys_iopl tip-bot for Brian Gerst
2009-12-10 0:57 ` [tip:x86/asm] x86-64, paravirt: Call set_iopl_mask() on 64 bits tip-bot for H. Peter Anvin
2009-12-10 0:01 ` [PATCH 3/6] x86: Merge sys_execve Brian Gerst
2009-12-10 0:46 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10 0:01 ` [PATCH 4/6] x86: Merge sys_sigaltstack Brian Gerst
2009-12-10 0:46 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10 0:01 ` [PATCH 5/6] x86, 32-bit: Convert sys_vm86 & sys_vm86old Brian Gerst
2009-12-10 0:46 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10 0:01 ` [PATCH 6/6] x86: Merge sys_clone Brian Gerst
2009-12-10 0:46 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10 0:47 ` [PATCH 0/6] x86: Merge pt_regs using syscalls H. Peter Anvin
2009-12-10 0:52 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260403316-5679-3-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.