All of lore.kernel.org
 help / color / mirror / Atom feed
From: "tip-bot for H. Peter Anvin" <hpa@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	brgerst@gmail.com, tglx@linutronix.de
Subject: [tip:x86/asm] x86-32: Avoid pipeline serialization in PTREGSCALL1 and 2
Date: Thu, 10 Dec 2009 00:47:12 GMT	[thread overview]
Message-ID: <tip-ce9119ad90b1caba550447bfcc0a21850558ca49@git.kernel.org> (raw)
In-Reply-To: <1260403316-5679-2-git-send-email-brgerst@gmail.com>

Commit-ID:  ce9119ad90b1caba550447bfcc0a21850558ca49
Gitweb:     http://git.kernel.org/tip/ce9119ad90b1caba550447bfcc0a21850558ca49
Author:     H. Peter Anvin <hpa@zytor.com>
AuthorDate: Wed, 9 Dec 2009 16:33:44 -0800
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Wed, 9 Dec 2009 16:33:44 -0800

x86-32: Avoid pipeline serialization in PTREGSCALL1 and 2

In the PTREGSCALL1 and 2 macros, we can trivially avoid an unnecessary
pipeline serialization, so do so.

In PTREGSCALLS3 this is much less clear-cut since we have to push a
new value to the stack.  Leave it alone for now assuming it is as good
as it is going to be; may want to check on Atom or another in-order
x86 to see if we can do better.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Brian Gerst <brgerst@gmail.com>
LKML-Reference: <1260403316-5679-2-git-send-email-brgerst@gmail.com>
---
 arch/x86/kernel/entry_32.S |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 6492555..cb12b9b 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -735,15 +735,15 @@ ptregs_##name: \
 	ALIGN; \
 ptregs_##name: \
 	leal 4(%esp),%edx; \
-	movl PT_EBX(%edx),%eax; \
+	movl (PT_EBX+4)(%esp),%eax; \
 	jmp sys_##name;
 
 #define PTREGSCALL2(name) \
 	ALIGN; \
 ptregs_##name: \
 	leal 4(%esp),%ecx; \
-	movl PT_ECX(%ecx),%edx; \
-	movl PT_EBX(%ecx),%eax; \
+	movl (PT_ECX+4)(%esp),%edx; \
+	movl (PT_EBX+4)(%esp),%eax; \
 	jmp sys_##name;
 
 #define PTREGSCALL3(name) \

  parent reply	other threads:[~2009-12-10  0:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10  0:01 [PATCH 0/6] x86: Merge pt_regs using syscalls Brian Gerst
2009-12-10  0:01 ` [PATCH 1/6] x86, 32-bit: Add new pt_regs stubs Brian Gerst
2009-12-10  0:05   ` H. Peter Anvin
2009-12-10  0:45   ` [tip:x86/asm] x86-32: " tip-bot for Brian Gerst
2009-12-10  0:47   ` tip-bot for H. Peter Anvin [this message]
2009-12-10  0:01 ` [PATCH 2/6] x86: Merge sys_iopl Brian Gerst
2009-12-10  0:45   ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10  0:57   ` [tip:x86/asm] x86-64, paravirt: Call set_iopl_mask() on 64 bits tip-bot for H. Peter Anvin
2009-12-10  0:01 ` [PATCH 3/6] x86: Merge sys_execve Brian Gerst
2009-12-10  0:46   ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10  0:01 ` [PATCH 4/6] x86: Merge sys_sigaltstack Brian Gerst
2009-12-10  0:46   ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10  0:01 ` [PATCH 5/6] x86, 32-bit: Convert sys_vm86 & sys_vm86old Brian Gerst
2009-12-10  0:46   ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10  0:01 ` [PATCH 6/6] x86: Merge sys_clone Brian Gerst
2009-12-10  0:46   ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-10  0:47 ` [PATCH 0/6] x86: Merge pt_regs using syscalls H. Peter Anvin
2009-12-10  0:52   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-ce9119ad90b1caba550447bfcc0a21850558ca49@git.kernel.org \
    --to=hpa@zytor.com \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.