Re: question about drivers/net/cpmac.c

[Ben Hutchings <bhutchings@solarflare.com>]

On Sun, 2009-12-13 at 12:00 +0100, Julia Lawall wrote:
> On Sun, 13 Dec 2009, David Miller wrote:
> 
> > From: Julia Lawall <julia@diku.dk>
> > Date: Sun, 13 Dec 2009 11:22:54 +0100 (CET)
> > 
> > > The function __devinit cpmac_probe in the file drivers/net/cpmac.c 
> > > contains the following code:
> > > 
> > > memcpy(dev->dev_addr, pdata->dev_addr, sizeof(dev->dev_addr));
> > > 
> > > Is it correct that the size of the pointer is what is wanted?
> > 
> > Everything that does sizeof(netdev->dev_addr) is a bug.
> > 
> > At some point we changed netdev->dev_addr from an array of chars to a
> > pointer to a dynamically allocated buffer.
> > 
> > So these cases worked before that change and need to be updated
> > in order to be correct.
> > 
> > Looking quickly there are a couple of these things under
> > drivers/net
> 
> Fixed how?  I looked a bit to find where the field was initialized, but it 
> is just initialized to a field of something else, so it was not so 
> clear what the size should be.
[...]

The size should be dev->addr_len (assuming that has already been
initialised) which will be ETH_ALEN for Ethernet devices.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.