From: David Miller <davem@davemloft.net>
To: julia@diku.dk
Cc: netdev@vger.kernel.org
Subject: Re: question about drivers/net/3c507.c
Date: Sun, 13 Dec 2009 02:40:16 -0800 (PST) [thread overview]
Message-ID: <20091213.024016.77044163.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0912131124100.24267@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Sun, 13 Dec 2009 11:25:02 +0100 (CET)
> The function __devinit cpmac_probe in the file drivers/net/3c507.c
> contains the following code:
>
> memcpy_toio(lp->base+SA_OFFSET, dev->dev_addr,
> sizeof(dev->dev_addr));
>
> Is it correct that the size of the pointer is what is wanted?
Same as the cpmac.c case, needs to be fixed.
next prev parent reply other threads:[~2009-12-13 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 10:22 question about drivers/net/cpmac.c Julia Lawall
2009-12-13 10:25 ` question about drivers/net/3c507.c Julia Lawall
2009-12-13 10:40 ` David Miller [this message]
2009-12-13 10:39 ` question about drivers/net/cpmac.c David Miller
2009-12-13 11:00 ` Julia Lawall
2009-12-13 11:51 ` Ben Hutchings
2009-12-13 12:19 ` Florian Fainelli
2009-12-13 12:43 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091213.024016.77044163.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=julia@diku.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.