[U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET

[U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET

[Marcel Ziswiler]

Delta and Zylonite both do not define CONFIG_CMD_NET by default and therefore
failed building:

lib_arm/libarm.a(board.o): In function `start_armboot':
/home/sumo/Noser/Linux/u-boot.git/lib_arm/board.c:360: undefined reference to `getenv_IPaddr'
make: *** [u-boot] Error 1

Saw that this got already fixed for ppc. Duno why nobody considered ARM as well!

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
---
 lib_arm/board.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib_arm/board.c b/lib_arm/board.c
index e148739..453d660 100644
--- a/lib_arm/board.c
+++ b/lib_arm/board.c
@@ -356,8 +356,10 @@ void start_armboot (void)
 	serial_initialize();
 #endif
 
+#ifdef CONFIG_CMD_NET
 	/* IP Address */
 	gd->bd->bi_ip_addr = getenv_IPaddr ("ipaddr");
+#endif
 
 	stdio_init ();	/* get the devices list going. */
 
-- 
1.6.0.4

[U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET

[Premi, Sanjeev]

 
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Marcel Ziswiler
> Sent: Thursday, December 24, 2009 7:39 AM
> To: u-boot at lists.denx.de
> Cc: sr at denx.de
> Subject: [U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET
> 
> Delta and Zylonite both do not define CONFIG_CMD_NET by 
> default and therefore
> failed building:
> 
> lib_arm/libarm.a(board.o): In function `start_armboot':
> /home/sumo/Noser/Linux/u-boot.git/lib_arm/board.c:360: 
> undefined reference to `getenv_IPaddr'
> make: *** [u-boot] Error 1
> 
> Saw that this got already fixed for ppc. Duno why nobody 
> considered ARM as well!
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
> ---
>  lib_arm/board.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/lib_arm/board.c b/lib_arm/board.c
> index e148739..453d660 100644
> --- a/lib_arm/board.c
> +++ b/lib_arm/board.c
> @@ -356,8 +356,10 @@ void start_armboot (void)
>  	serial_initialize();
>  #endif
>  
> +#ifdef CONFIG_CMD_NET
>  	/* IP Address */
>  	gd->bd->bi_ip_addr = getenv_IPaddr ("ipaddr");
> +#endif
>  
>  	stdio_init ();	/* get the devices list going. */
>  

I had already sent a patch earlier with the same fix.
Noticed it on beagle.

See: http://www.mail-archive.com/u-boot at lists.denx.de/msg26870.html
     [PATCH] omap3: beagle: fix compile error 

Best regards,
Sanjeev

> -- 
> 1.6.0.4
> 
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

[U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET

[Premi, Sanjeev]

 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
> Sent: Thursday, December 24, 2009 6:43 PM
> To: Marcel Ziswiler; u-boot at lists.denx.de
> Cc: sr at denx.de
> Subject: Re: [U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET
> 
>  
> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de 
> > [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Marcel Ziswiler
> > Sent: Thursday, December 24, 2009 7:39 AM
> > To: u-boot at lists.denx.de
> > Cc: sr at denx.de
> > Subject: [U-Boot] [PATCH] ARM: Fix building without CONFIG_CMD_NET
> > 
> > Delta and Zylonite both do not define CONFIG_CMD_NET by 
> > default and therefore
> > failed building:
> > 
> > lib_arm/libarm.a(board.o): In function `start_armboot':
> > /home/sumo/Noser/Linux/u-boot.git/lib_arm/board.c:360: 
> > undefined reference to `getenv_IPaddr'
> > make: *** [u-boot] Error 1
> > 
> > Saw that this got already fixed for ppc. Duno why nobody 
> > considered ARM as well!
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@noser.com>
> > ---
> >  lib_arm/board.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/lib_arm/board.c b/lib_arm/board.c
> > index e148739..453d660 100644
> > --- a/lib_arm/board.c
> > +++ b/lib_arm/board.c
> > @@ -356,8 +356,10 @@ void start_armboot (void)
> >  	serial_initialize();
> >  #endif
> >  
> > +#ifdef CONFIG_CMD_NET
> >  	/* IP Address */
> >  	gd->bd->bi_ip_addr = getenv_IPaddr ("ipaddr");
> > +#endif
> >  
> >  	stdio_init ();	/* get the devices list going. */
> >  
> 
> I had already sent a patch earlier with the same fix.
> Noticed it on beagle.
> 
> See: http://www.mail-archive.com/u-boot at lists.denx.de/msg26870.html
>      [PATCH] omap3: beagle: fix compile error 

Sorry, pasted incorrect url. Here is the right one:
     http://www.mail-archive.com/u-boot at lists.denx.de/msg26845.html

~sanjeev
> 
> Best regards,
> Sanjeev
> 
> > -- 
> > 1.6.0.4
> > 
> > 
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> > http://lists.denx.de/mailman/listinfo/u-boot
> > 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>