From: Stefani Seibold <stefani@seibold.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] proc: revert to show stack information in /proc/{pid}/status
Date: Fri, 01 Jan 2010 17:09:53 +0100 [thread overview]
Message-ID: <1262362193.14370.6.camel@wall-e> (raw)
In-Reply-To: <87pr5t7rli.fsf@basil.nowhere.org>
Am Freitag, den 01.01.2010, 16:49 +0100 schrieb Andi Kleen:
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> writes:
> >
> > Anyway, I revert the regresstion patch as other regression patches. if you really want
> > this feature, you have three options.
> >
> > 1. create new /proc file instead to use /proc/pid/status.
> > 2. improve performance until typical use-case don't notice regression.
> > 3. change ps and other /proc related userland implementation and resubmit this patch.
> >
> > But even if you choose anything, You have to test both its functional and performance
> > _before_ submitting kernel patch.
>
>
> 4. Leave everything alone (revert all the commits) and use a ptrace
> based tool to get this information when you need it.
>
Without the stack_start and the fix for the bogus x86_64 KSTP_ESP it
wouldn't be possible.
next prev parent reply other threads:[~2010-01-01 16:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 14:12 [PATCH] proc: revert to show stack information in /proc/{pid}/status KOSAKI Motohiro
2009-12-31 15:48 ` Stefani Seibold
2010-01-01 14:14 ` KOSAKI Motohiro
2010-01-01 15:10 ` Stefani Seibold
2010-01-01 22:05 ` Samuel Thibault
2010-01-01 22:21 ` Stefani Seibold
2010-01-02 5:53 ` KOSAKI Motohiro
2010-01-02 8:26 ` Stefani Seibold
2010-01-02 14:05 ` [PATCH] partial revert to show stack information in /proc/<pid>/status Stefani Seibold
2010-01-05 5:24 ` KOSAKI Motohiro
2010-01-02 1:42 ` [PATCH] proc: revert to show stack information in /proc/{pid}/status Andi Kleen
2010-01-01 15:49 ` Andi Kleen
2010-01-01 16:09 ` Stefani Seibold [this message]
2010-01-07 21:52 ` Andrew Morton
2010-01-08 0:21 ` KOSAKI Motohiro
2010-01-08 0:34 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262362193.14370.6.camel@wall-e \
--to=stefani@seibold.net \
--cc=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=ebiederm@xmission.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.