* [PATCH] sunrpc: fix build-time warning @ 2009-12-31 2:23 Jeff Layton 2009-12-31 17:18 ` Randy Dunlap 0 siblings, 1 reply; 9+ messages in thread From: Jeff Layton @ 2009-12-31 2:23 UTC (permalink / raw) To: Trond Myklebust; +Cc: Stephen Rothwell, linux-kernel, linux-nfs Commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a introduced this warning at build time on some 32-bit architectures: net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall': net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t ...fix it by changing the length modifier in the printk. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Jeff Layton <jlayton@redhat.com> --- net/sunrpc/auth_gss/auth_gss.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c index 66cb89c..6de4f91 100644 --- a/net/sunrpc/auth_gss/auth_gss.c +++ b/net/sunrpc/auth_gss/auth_gss.c @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) break; default: printk(KERN_CRIT "%s: bad return from " - "gss_fill_context: %ld\n", __func__, err); + "gss_fill_context: %Zd\n", __func__, err); BUG(); } goto err_release_msg; -- 1.6.5.2 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] sunrpc: fix build-time warning 2009-12-31 2:23 [PATCH] sunrpc: fix build-time warning Jeff Layton @ 2009-12-31 17:18 ` Randy Dunlap 2010-01-01 1:54 ` Jeff Layton 0 siblings, 1 reply; 9+ messages in thread From: Randy Dunlap @ 2009-12-31 17:18 UTC (permalink / raw) To: Jeff Layton; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs On Wed, 30 Dec 2009 21:23:15 -0500 Jeff Layton wrote: > Commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a introduced this warning > at build time on some 32-bit architectures: > > net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall': > net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t > > ...fix it by changing the length modifier in the printk. > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Jeff Layton <jlayton@redhat.com> > --- > net/sunrpc/auth_gss/auth_gss.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > index 66cb89c..6de4f91 100644 > --- a/net/sunrpc/auth_gss/auth_gss.c > +++ b/net/sunrpc/auth_gss/auth_gss.c > @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) > break; > default: > printk(KERN_CRIT "%s: bad return from " > - "gss_fill_context: %ld\n", __func__, err); > + "gss_fill_context: %Zd\n", __func__, err); > BUG(); > } > goto err_release_msg; > -- I have that almost-same patch in my (unposted) linux-next patch queue, so basically, ack, except that we try to use 'z' instead of 'Z' nowadays. My quick kernel source tree count is 173 %Z to 966 %z. (Please don't anyone start a project of converting %Z to %z.) --- ~Randy ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] sunrpc: fix build-time warning 2009-12-31 17:18 ` Randy Dunlap @ 2010-01-01 1:54 ` Jeff Layton [not found] ` <20091231205454.0f84f091-PC62bkCOHzGdMjc06nkz3ljfA9RmPOcC@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Jeff Layton @ 2010-01-01 1:54 UTC (permalink / raw) To: Randy Dunlap; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs On Thu, 31 Dec 2009 09:18:15 -0800 Randy Dunlap <rdunlap@xenotime.net> wrote: > On Wed, 30 Dec 2009 21:23:15 -0500 Jeff Layton wrote: > > > Commit 486bad2e40e938cd68fd853b7a9fa3115a9d3a4a introduced this warning > > at build time on some 32-bit architectures: > > > > net/sunrpc/auth_gss/auth_gss.c: In function 'gss_pipe_downcall': > > net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t > > > > ...fix it by changing the length modifier in the printk. > > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Signed-off-by: Jeff Layton <jlayton@redhat.com> > > --- > > net/sunrpc/auth_gss/auth_gss.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > > index 66cb89c..6de4f91 100644 > > --- a/net/sunrpc/auth_gss/auth_gss.c > > +++ b/net/sunrpc/auth_gss/auth_gss.c > > @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, const char __user *src, size_t mlen) > > break; > > default: > > printk(KERN_CRIT "%s: bad return from " > > - "gss_fill_context: %ld\n", __func__, err); > > + "gss_fill_context: %Zd\n", __func__, err); > > BUG(); > > } > > goto err_release_msg; > > -- > > I have that almost-same patch in my (unposted) linux-next patch queue, > so basically, ack, except that we try to use 'z' instead of 'Z' nowadays. > > My quick kernel source tree count is 173 %Z to 966 %z. > (Please don't anyone start a project of converting %Z to %z.) > If you have a patch queued up for this with the preferred qualifier, then I'm fine with dropping this one. Cheers, -- Jeff Layton <jlayton@redhat.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <20091231205454.0f84f091-PC62bkCOHzGdMjc06nkz3ljfA9RmPOcC@public.gmane.org>]
* [PATCH v2] sunrpc: fix build-time warning 2010-01-01 1:54 ` Jeff Layton @ 2010-01-02 2:25 ` Randy Dunlap 0 siblings, 0 replies; 9+ messages in thread From: Randy Dunlap @ 2010-01-02 2:25 UTC (permalink / raw) To: Jeff Layton; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs From: Randy Dunlap <randy.dunlap@oracle.com> Fix auth_gss printk format warning: net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- net/sunrpc/auth_gss/auth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20091229.orig/net/sunrpc/auth_gss/auth_gss.c +++ linux-next-20091229/net/sunrpc/auth_gss/auth_gss.c @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, con break; default: printk(KERN_CRIT "%s: bad return from " - "gss_fill_context: %ld\n", __func__, err); + "gss_fill_context: %zd\n", __func__, err); BUG(); } goto err_release_msg; --- ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] sunrpc: fix build-time warning @ 2010-01-02 2:25 ` Randy Dunlap 0 siblings, 0 replies; 9+ messages in thread From: Randy Dunlap @ 2010-01-02 2:25 UTC (permalink / raw) To: Jeff Layton; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs From: Randy Dunlap <randy.dunlap@oracle.com> Fix auth_gss printk format warning: net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- net/sunrpc/auth_gss/auth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20091229.orig/net/sunrpc/auth_gss/auth_gss.c +++ linux-next-20091229/net/sunrpc/auth_gss/auth_gss.c @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, con break; default: printk(KERN_CRIT "%s: bad return from " - "gss_fill_context: %ld\n", __func__, err); + "gss_fill_context: %zd\n", __func__, err); BUG(); } goto err_release_msg; --- ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] sunrpc: fix build-time warning 2010-01-02 2:25 ` Randy Dunlap (?) @ 2010-01-03 11:51 ` Jeff Layton -1 siblings, 0 replies; 9+ messages in thread From: Jeff Layton @ 2010-01-03 11:51 UTC (permalink / raw) To: Randy Dunlap; +Cc: Trond Myklebust, Stephen Rothwell, linux-kernel, linux-nfs On Fri, 1 Jan 2010 18:25:14 -0800 Randy Dunlap <randy.dunlap@oracle.com> wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > Fix auth_gss printk format warning: > > net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Acked-by: Jeff Layton <jlayton@redhat.com> > --- > net/sunrpc/auth_gss/auth_gss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20091229.orig/net/sunrpc/auth_gss/auth_gss.c > +++ linux-next-20091229/net/sunrpc/auth_gss/auth_gss.c > @@ -657,7 +657,7 @@ gss_pipe_downcall(struct file *filp, con > break; > default: > printk(KERN_CRIT "%s: bad return from " > - "gss_fill_context: %ld\n", __func__, err); > + "gss_fill_context: %zd\n", __func__, err); > BUG(); > } > goto err_release_msg; > --- -- Jeff Layton <jlayton@redhat.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] sunrpc: fix build-time warning 2010-01-02 2:25 ` Randy Dunlap (?) (?) @ 2010-01-06 23:10 ` Trond Myklebust 2010-01-06 23:51 ` Stephen Rothwell -1 siblings, 1 reply; 9+ messages in thread From: Trond Myklebust @ 2010-01-06 23:10 UTC (permalink / raw) To: Randy Dunlap; +Cc: Jeff Layton, Stephen Rothwell, linux-kernel, linux-nfs On Fri, 2010-01-01 at 18:25 -0800, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > Fix auth_gss printk format warning: > > net/sunrpc/auth_gss/auth_gss.c:660: warning: format '%ld' expects type 'long int', but argument 3 has type 'ssize_t' > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Thanks Randy! Sorry for the delay. This patch has been applied today, and should therefore appear in the linux-next tree tomorrow... Cheers Trond ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] sunrpc: fix build-time warning 2010-01-06 23:10 ` Trond Myklebust @ 2010-01-06 23:51 ` Stephen Rothwell 0 siblings, 0 replies; 9+ messages in thread From: Stephen Rothwell @ 2010-01-06 23:51 UTC (permalink / raw) To: Trond Myklebust; +Cc: Randy Dunlap, Jeff Layton, linux-kernel, linux-nfs [-- Attachment #1: Type: text/plain, Size: 485 bytes --] Hi Trond, On Wed, 06 Jan 2010 18:10:20 -0500 Trond Myklebust <trond.myklebust-N1bbTUo86Qc@public.gmane.org.no> wrote: > > Sorry for the delay. This patch has been applied today, and should > therefore appear in the linux-next tree tomorrow... Actually today - since I am following the normal Australian practice of being slack and starting work late in January :-) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] sunrpc: fix build-time warning @ 2010-01-06 23:51 ` Stephen Rothwell 0 siblings, 0 replies; 9+ messages in thread From: Stephen Rothwell @ 2010-01-06 23:51 UTC (permalink / raw) To: Trond Myklebust; +Cc: Randy Dunlap, Jeff Layton, linux-kernel, linux-nfs [-- Attachment #1: Type: text/plain, Size: 464 bytes --] Hi Trond, On Wed, 06 Jan 2010 18:10:20 -0500 Trond Myklebust <trond.myklebust@fys.uio.no> wrote: > > Sorry for the delay. This patch has been applied today, and should > therefore appear in the linux-next tree tomorrow... Actually today - since I am following the normal Australian practice of being slack and starting work late in January :-) -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2010-01-06 23:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-31 2:23 [PATCH] sunrpc: fix build-time warning Jeff Layton
2009-12-31 17:18 ` Randy Dunlap
2010-01-01 1:54 ` Jeff Layton
[not found] ` <20091231205454.0f84f091-PC62bkCOHzGdMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2010-01-02 2:25 ` [PATCH v2] " Randy Dunlap
2010-01-02 2:25 ` Randy Dunlap
2010-01-03 11:51 ` Jeff Layton
2010-01-06 23:10 ` Trond Myklebust
2010-01-06 23:51 ` Stephen Rothwell
2010-01-06 23:51 ` Stephen Rothwell
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.