From: Matt Mackall <mpm@selenic.com>
To: Daniel Borkmann <danborkmann@googlemail.com>
Cc: linux-kernel@vger.kernel.org, Jeff Moyer <jmoyer@redhat.com>,
netdev@vger.kernel.org, netdev@oss.sgi.com,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface
Date: Wed, 06 Jan 2010 21:54:05 -0600 [thread overview]
Message-ID: <1262836445.29868.227.camel@calx> (raw)
In-Reply-To: <4B44F895.9080205@gmail.com>
On Wed, 2010-01-06 at 21:54 +0100, Daniel Borkmann wrote:
> Hi,
>
> this patch allows the registration and _execution_ of multiple netpoll
> rx_hooks per interface. Currently, it is possible to register multiple
> netpoll structures to one interface, _but_ only one single rx_hook (from
> the netpoll struct that has been registered last) can be executed, which
> was an oversight in the implementation [1].
> So, this patch fixes it. I've sucessfully tested it within 2.6.32.2 with
> the registration of multiple rx_hook clients for several times. I'd
> appreciate comments / feedback.
(grumbles about cc:)
Please inline patches so they can be reviewed easily in reply.
- struct netpoll *np = npi->rx_np;
+ struct netpoll **np = &npi->rx_np;
- if (!np)
+ if (!(*np))
This makes everything horrible. Can you avoid the double indirection?
Using a list head might be a good answer.
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2010-01-07 3:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:54 [PATCH] netpoll: allow execution of multiple rx_hooks per interface Daniel Borkmann
2010-01-07 3:54 ` Matt Mackall [this message]
2010-01-07 9:02 ` David Miller
2010-01-07 19:06 ` Daniel Borkmann
2010-01-08 0:20 ` Daniel Borkmann
2010-01-11 23:21 ` Matt Mackall
2010-01-11 23:59 ` David Miller
2010-01-12 0:03 ` Matt Mackall
2010-01-12 0:09 ` Daniel Borkmann
2010-01-13 0:27 ` Daniel Borkmann
2010-01-13 13:57 ` Jeff Moyer
2010-01-13 16:53 ` Daniel Borkmann
2010-01-13 16:53 ` Daniel Borkmann
2010-01-14 4:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262836445.29868.227.camel@calx \
--to=mpm@selenic.com \
--cc=danborkmann@googlemail.com \
--cc=davem@davemloft.net \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.