All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francisco Alecrim <alecrim@gmail.com>
To: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Francisco Alecrim <francisco.alecrim@openbossa.org>
Subject: [RFC/PATCH 1/2] usb_otg: compile fix
Date: Thu,  7 Jan 2010 21:03:11 -0400	[thread overview]
Message-ID: <1262912592-7817-1-git-send-email-alecrim@gmail.com> (raw)

From: Francisco Alecrim <francisco.alecrim@openbossa.org>

include/linux/usb.h: In function 'usb_mark_last_busy':
include/linux/usb.h:561: error: 'struct usb_device' has no member named
'last_busy'

Option USB_OTG selects USB_SUSPEND but doesn't select PM(required by
USB_SUSPEND) causing this compile error. Putting USB_SUSPEND as
USB_OTG depend ensure that PM is selected.

Signed-off-by: Francisco Alecrim <francisco.alecrim@openbossa.org>
---
 drivers/usb/core/Kconfig   |    1 -
 drivers/usb/gadget/Kconfig |    2 +-
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
index ad92594..4c7d6e8 100644
--- a/drivers/usb/core/Kconfig
+++ b/drivers/usb/core/Kconfig
@@ -109,7 +109,6 @@ config USB_SUSPEND
 config USB_OTG
 	bool
 	depends on USB && EXPERIMENTAL
-	select USB_SUSPEND
 	default n
 
 
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index ee41120..af819fe 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -211,7 +211,7 @@ config USB_OMAP
 
 config USB_OTG
 	boolean "OTG Support"
-	depends on USB_GADGET_OMAP && ARCH_OMAP_OTG && USB_OHCI_HCD
+	depends on USB_GADGET_OMAP && ARCH_OMAP_OTG && USB_OHCI_HCD && USB_SUSPEND
 	help
 	   The most notable feature of USB OTG is support for a
 	   "Dual-Role" device, which can act as either a device
-- 
1.6.3.3


             reply	other threads:[~2010-01-08  1:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-08  1:03 Francisco Alecrim [this message]
     [not found] ` <1262912592-7817-1-git-send-email-alecrim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-01-08  1:03   ` [RFC/PATCH 2/2] fix compile for tahvo-usb.c Francisco Alecrim
2010-01-11 23:33     ` [APPLIED] " Tony Lindgren
2010-01-08  5:43   ` [RFC/PATCH 1/2] usb_otg: compile fix Felipe Balbi
2010-01-08  5:57     ` Felipe Balbi
2010-01-08  4:15 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262912592-7817-1-git-send-email-alecrim@gmail.com \
    --to=alecrim@gmail.com \
    --cc=francisco.alecrim@openbossa.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.