From: Olof Johansson <olof@lixom.net>
To: Francisco Alecrim <alecrim@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
Francisco Alecrim <francisco.alecrim@openbossa.org>
Subject: Re: [RFC/PATCH 1/2] usb_otg: compile fix
Date: Thu, 7 Jan 2010 22:15:29 -0600 [thread overview]
Message-ID: <20100108041529.GA28076@lixom.net> (raw)
In-Reply-To: <1262912592-7817-1-git-send-email-alecrim@gmail.com>
On Thu, Jan 07, 2010 at 09:03:11PM -0400, Francisco Alecrim wrote:
> From: Francisco Alecrim <francisco.alecrim@openbossa.org>
>
> include/linux/usb.h: In function 'usb_mark_last_busy':
> include/linux/usb.h:561: error: 'struct usb_device' has no member named
> 'last_busy'
>
> Option USB_OTG selects USB_SUSPEND but doesn't select PM(required by
> USB_SUSPEND) causing this compile error. Putting USB_SUSPEND as
> USB_OTG depend ensure that PM is selected.
For me it seems sufficient to just remove the select of USB_SUSPEND.
USB_OTG compiles fine without it.
Seems harsh to require someone to enable CONFIG_PM and USB_SUSPEND just
to compile OTG drivers.
-Olof
prev parent reply other threads:[~2010-01-08 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 1:03 [RFC/PATCH 1/2] usb_otg: compile fix Francisco Alecrim
[not found] ` <1262912592-7817-1-git-send-email-alecrim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-01-08 1:03 ` [RFC/PATCH 2/2] fix compile for tahvo-usb.c Francisco Alecrim
2010-01-11 23:33 ` [APPLIED] " Tony Lindgren
2010-01-08 5:43 ` [RFC/PATCH 1/2] usb_otg: compile fix Felipe Balbi
2010-01-08 5:57 ` Felipe Balbi
2010-01-08 4:15 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100108041529.GA28076@lixom.net \
--to=olof@lixom.net \
--cc=alecrim@gmail.com \
--cc=francisco.alecrim@openbossa.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.