From: Ben Dooks <ben-linux@fluff.org>
To: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Ben Dooks <ben-linux@fluff.org>
Subject: [PATCH] ARM: S5PC1XX: Register pd0 and hd0 clocks, remove unecessary dummy_enable
Date: Mon, 18 Jan 2010 08:42:53 +0000 [thread overview]
Message-ID: <1263804176-8417-2-git-send-email-ben-linux@fluff.org> (raw)
In-Reply-To: <1263804176-8417-1-git-send-email-ben-linux@fluff.org>
The clk_hd0 and clk_pd0 where given a local dummy_enable call due to
not being registered with the clock code, which they really should have
been. Register these two clocks and remove the clk_dummy_enable as this
is done by the default clock registration code.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
arch/arm/plat-s5pc1xx/clock.c | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/arm/plat-s5pc1xx/clock.c b/arch/arm/plat-s5pc1xx/clock.c
index aec0305..387f231 100644
--- a/arch/arm/plat-s5pc1xx/clock.c
+++ b/arch/arm/plat-s5pc1xx/clock.c
@@ -64,18 +64,12 @@ struct clk clk_54m = {
.rate = 54000000,
};
-static int clk_dummy_enable(struct clk *clk, int enable)
-{
- return 0;
-}
-
struct clk clk_hd0 = {
.name = "hclkd0",
.id = -1,
.rate = 0,
.parent = NULL,
.ctrlbit = 0,
- .enable = clk_dummy_enable,
.ops = &clk_ops_def_setrate,
};
@@ -86,7 +80,6 @@ struct clk clk_pd0 = {
.parent = NULL,
.ctrlbit = 0,
.ops = &clk_ops_def_setrate,
- .enable = clk_dummy_enable,
};
static int s5pc1xx_clk_gate(void __iomem *reg, struct clk *clk, int enable)
@@ -680,6 +673,8 @@ static struct clk s5pc100_init_clocks[] = {
static struct clk *clks[] __initdata = {
&clk_ext,
&clk_epll,
+ &clk_pd0,
+ &clk_hd0,
&clk_27m,
&clk_48m,
&clk_54m,
--
1.6.0.4
WARNING: multiple messages have this Message-ID (diff)
From: ben-linux@fluff.org (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5PC1XX: Register pd0 and hd0 clocks, remove unecessary dummy_enable
Date: Mon, 18 Jan 2010 08:42:53 +0000 [thread overview]
Message-ID: <1263804176-8417-2-git-send-email-ben-linux@fluff.org> (raw)
In-Reply-To: <1263804176-8417-1-git-send-email-ben-linux@fluff.org>
The clk_hd0 and clk_pd0 where given a local dummy_enable call due to
not being registered with the clock code, which they really should have
been. Register these two clocks and remove the clk_dummy_enable as this
is done by the default clock registration code.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
---
arch/arm/plat-s5pc1xx/clock.c | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/arch/arm/plat-s5pc1xx/clock.c b/arch/arm/plat-s5pc1xx/clock.c
index aec0305..387f231 100644
--- a/arch/arm/plat-s5pc1xx/clock.c
+++ b/arch/arm/plat-s5pc1xx/clock.c
@@ -64,18 +64,12 @@ struct clk clk_54m = {
.rate = 54000000,
};
-static int clk_dummy_enable(struct clk *clk, int enable)
-{
- return 0;
-}
-
struct clk clk_hd0 = {
.name = "hclkd0",
.id = -1,
.rate = 0,
.parent = NULL,
.ctrlbit = 0,
- .enable = clk_dummy_enable,
.ops = &clk_ops_def_setrate,
};
@@ -86,7 +80,6 @@ struct clk clk_pd0 = {
.parent = NULL,
.ctrlbit = 0,
.ops = &clk_ops_def_setrate,
- .enable = clk_dummy_enable,
};
static int s5pc1xx_clk_gate(void __iomem *reg, struct clk *clk, int enable)
@@ -680,6 +673,8 @@ static struct clk s5pc100_init_clocks[] = {
static struct clk *clks[] __initdata = {
&clk_ext,
&clk_epll,
+ &clk_pd0,
+ &clk_hd0,
&clk_27m,
&clk_48m,
&clk_54m,
--
1.6.0.4
next prev parent reply other threads:[~2010-01-18 8:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 8:42 Samsung Clock updates #2 Ben Dooks
2010-01-18 8:42 ` Ben Dooks
2010-01-18 8:42 ` Ben Dooks [this message]
2010-01-18 8:42 ` [PATCH] ARM: S5PC1XX: Register pd0 and hd0 clocks, remove unecessary dummy_enable Ben Dooks
2010-01-18 8:42 ` [PATCH] ARM: SAMSUNG: Add check to ensure that clksrc_clk does have multiple clock sources Ben Dooks
2010-01-18 8:42 ` Ben Dooks
2010-01-18 8:42 ` [PATCH] ARM: SAMSUNG: Fix clksrc-clk's checks for bad register settings Ben Dooks
2010-01-18 8:42 ` Ben Dooks
2010-01-18 8:42 ` [PATCH] ARM: SAMSUNG: Fix bug in clksrc-clk round_rate call Ben Dooks
2010-01-18 8:42 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263804176-8417-2-git-send-email-ben-linux@fluff.org \
--to=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.