From: lrg@slimlogic.co.uk (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/01] regulator: support max8649
Date: Tue, 26 Jan 2010 16:10:49 +0000 [thread overview]
Message-ID: <1264522249.3067.79.camel@odin> (raw)
In-Reply-To: <771cded01001260414q4c8df1e0k303772b87bc725eb@mail.gmail.com>
On Tue, 2010-01-26 at 07:14 -0500, Haojian Zhuang wrote:
> On Tue, Jan 26, 2010 at 7:00 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > On Tue, Jan 26, 2010 at 06:54:48AM -0500, Haojian Zhuang wrote:
> >> On Tue, Jan 26, 2010 at 6:04 AM, Mark Brown
> >
> >> > I'd expect the time taken to enable to be the voltage multipled by the
> >> > step size rather than divided by the step size?
> >
> >> I don't agree at this point. The unit of step is uV/uSec. The function
> >> should return uSec. So voltage divided by the step is more reasonable.
> >
> > Ah, then the variable step is confusingly named since it's actually a
> > rate of change rather than a step size - I'd suggest rate or something
> > like that instead.
> >
>
> update this patch.
>
Applied.
Thanks
Liam
WARNING: multiple messages have this Message-ID (diff)
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 01/01] regulator: support max8649
Date: Tue, 26 Jan 2010 16:10:49 +0000 [thread overview]
Message-ID: <1264522249.3067.79.camel@odin> (raw)
In-Reply-To: <771cded01001260414q4c8df1e0k303772b87bc725eb@mail.gmail.com>
On Tue, 2010-01-26 at 07:14 -0500, Haojian Zhuang wrote:
> On Tue, Jan 26, 2010 at 7:00 AM, Mark Brown
> <broonie@opensource.wolfsonmicro.com> wrote:
> > On Tue, Jan 26, 2010 at 06:54:48AM -0500, Haojian Zhuang wrote:
> >> On Tue, Jan 26, 2010 at 6:04 AM, Mark Brown
> >
> >> > I'd expect the time taken to enable to be the voltage multipled by the
> >> > step size rather than divided by the step size?
> >
> >> I don't agree at this point. The unit of step is uV/uSec. The function
> >> should return uSec. So voltage divided by the step is more reasonable.
> >
> > Ah, then the variable step is confusingly named since it's actually a
> > rate of change rather than a step size - I'd suggest rate or something
> > like that instead.
> >
>
> update this patch.
>
Applied.
Thanks
Liam
next prev parent reply other threads:[~2010-01-26 16:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 8:41 [PATCH 01/01] regulator: support max8649 Haojian Zhuang
2010-01-12 8:51 ` Haojian Zhuang
2010-01-12 11:51 ` Mark Brown
2010-01-12 11:51 ` Mark Brown
2010-01-25 11:01 ` Haojian Zhuang
2010-01-25 11:01 ` Haojian Zhuang
2010-01-25 13:56 ` Mark Brown
2010-01-25 13:56 ` Mark Brown
2010-01-26 6:26 ` Haojian Zhuang
2010-01-26 6:26 ` Haojian Zhuang
2010-01-26 11:01 ` Liam Girdwood
2010-01-26 11:01 ` Liam Girdwood
2010-01-26 11:51 ` Haojian Zhuang
2010-01-26 11:51 ` Haojian Zhuang
2010-01-26 11:04 ` Mark Brown
2010-01-26 11:04 ` Mark Brown
2010-01-26 11:54 ` Haojian Zhuang
2010-01-26 11:54 ` Haojian Zhuang
2010-01-26 12:00 ` Mark Brown
2010-01-26 12:00 ` Mark Brown
2010-01-26 12:14 ` Haojian Zhuang
2010-01-26 12:14 ` Haojian Zhuang
2010-01-26 12:41 ` Mark Brown
2010-01-26 12:41 ` Mark Brown
2010-01-26 16:10 ` Liam Girdwood [this message]
2010-01-26 16:10 ` Liam Girdwood
2010-03-08 6:28 ` Haojian Zhuang
2010-03-08 6:28 ` Haojian Zhuang
2010-03-08 8:18 ` Liam Girdwood
2010-03-08 8:18 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264522249.3067.79.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.