All of lore.kernel.org
 help / color / mirror / Atom feed
From: peterz@infradead.org (Peter Zijlstra)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/1] Extended events (platform-specific) support in perf
Date: Wed, 27 Jan 2010 12:35:23 +0100	[thread overview]
Message-ID: <1264592123.4283.2013.camel@laptop> (raw)
In-Reply-To: <1264162139-26788-2-git-send-email-t.fujak@samsung.com>

On Fri, 2010-01-22 at 13:08 +0100, Tomasz Fujak wrote:

there's supposed to be a changelog here...

> Signed-off-by: Tomasz Fujak <t.fujak@samsung.com>
> Reviewed-by: Pawel Osciak <p.osciak@samsung.com>
> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Kyungmin Park <kuyngmin.park@samsung.com>

Surely one of you knew that ;-)

Anyway, I still think it stinks, and as pointed out, it violates the
one-value-per-file sysfs rule.

I really see no reason why you cannot do this in userspace, have
tools/perf/ provide a library that does this for all supported platforms
with a common interface or something.

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Tomasz Fujak <t.fujak@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, acme@redhat.com,
	jamie.iles@picochip.com, will.deacon@arm.com, jpihet@mvista.com,
	mingo@elte.hu, p.osciak@samsung.com, m.szyprowski@samsung.com,
	kyungmin.park@samsung.com
Subject: Re: [PATCH v1 1/1] Extended events (platform-specific) support in perf
Date: Wed, 27 Jan 2010 12:35:23 +0100	[thread overview]
Message-ID: <1264592123.4283.2013.camel@laptop> (raw)
In-Reply-To: <1264162139-26788-2-git-send-email-t.fujak@samsung.com>

On Fri, 2010-01-22 at 13:08 +0100, Tomasz Fujak wrote:

there's supposed to be a changelog here...

> Signed-off-by: Tomasz Fujak <t.fujak@samsung.com>
> Reviewed-by: Pawel Osciak <p.osciak@samsung.com>
> Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Kyungmin Park <kuyngmin.park@samsung.com>

Surely one of you knew that ;-)

Anyway, I still think it stinks, and as pointed out, it violates the
one-value-per-file sysfs rule.

I really see no reason why you cannot do this in userspace, have
tools/perf/ provide a library that does this for all supported platforms
with a common interface or something.




  parent reply	other threads:[~2010-01-27 11:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 12:08 [PATCH/RFC v1 0/1] Platform-specific event support in the perf Tomasz Fujak
2010-01-22 12:08 ` Tomasz Fujak
2010-01-22 12:08 ` [PATCH v1 1/1] Extended events (platform-specific) support in perf Tomasz Fujak
2010-01-22 12:08   ` Tomasz Fujak
2010-01-22 12:26   ` Arnaldo Carvalho de Melo
2010-01-22 12:26     ` Arnaldo Carvalho de Melo
2010-01-22 13:08     ` Tomasz Fujak
2010-01-22 13:08       ` Tomasz Fujak
2010-01-27 11:35   ` Peter Zijlstra [this message]
2010-01-27 11:35     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264592123.4283.2013.camel@laptop \
    --to=peterz@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.