All of lore.kernel.org
 help / color / mirror / Atom feed
From: adharmap@codeaurora.org
To: linux-arm-kernel@lists.infradead.org
Cc: Russell King <linux@arm.linux.org.uk>,
	Ingo Molnar <mingo@elte.hu>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Yinghai Lu <yinghai@kernel.org>, Tony Lindgren <tony@atomide.com>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Kalle Valo <kalle.valo@iki.fi>, Jean Pihet <jpihet@mvista.com>,
	Linus Walleij <linus.walleij@stericsson.com>,
	Colin Tuckley <colin.tuckley@arm.com>,
	Philby John <pjohn@in.mvista.com>,
	Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
	Alessandro Rubini <rubini@unipv.it>,
	Andrea Gallo <andrea.gallo@stericsson.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	Abhijeet Dharmapurikar <adharmap@quicinc.com>
Subject: [PATCH 1/5] gic: prevent gic from crossing NR_IRQ
Date: Wed, 27 Jan 2010 11:32:25 -0800	[thread overview]
Message-ID: <1264620749-24527-2-git-send-email-adharmap@codeaurora.org> (raw)
In-Reply-To: <1264620749-24527-1-git-send-email-adharmap@codeaurora.org>

From: Abhijeet Dharmapurikar <adharmap@quicinc.com>

The gic code tries to initialize interrupts beyond NR_IRQ. Prevent
code from doing that.

Signed-off-by: Abhijeet Dharmapurikar <adharmap@quicinc.com>
---
 arch/arm/common/gic.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index 337741f..e763c4c 100644
--- a/arch/arm/common/gic.c
+++ b/arch/arm/common/gic.c
@@ -175,6 +175,11 @@ void __init gic_cascade_irq(unsigned int gic_nr, unsigned int irq)
 	set_irq_chained_handler(irq, gic_handle_cascade_irq);
 }
 
+/*
+ * In case of multiple cascaded GICs, order calls to gic_dist_init with
+ * ascending irq_start
+ */
+
 void __init gic_dist_init(unsigned int gic_nr, void __iomem *base,
 			  unsigned int irq_start)
 {
@@ -233,7 +238,7 @@ void __init gic_dist_init(unsigned int gic_nr, void __iomem *base,
 	/*
 	 * Setup the Linux IRQ subsystem.
 	 */
-	for (i = irq_start; i < gic_data[gic_nr].irq_offset + max_irq; i++) {
+	for (i = irq_start; i < NR_IRQS && i < gic_data[gic_nr].irq_offset + max_irq; i++) {
 		set_irq_chip(i, &gic_chip);
 		set_irq_chip_data(i, &gic_data[gic_nr]);
 		set_irq_handler(i, handle_level_irq);
-- 
1.5.6.3


WARNING: multiple messages have this Message-ID (diff)
From: adharmap@codeaurora.org (adharmap at codeaurora.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] gic: prevent gic from crossing NR_IRQ
Date: Wed, 27 Jan 2010 11:32:25 -0800	[thread overview]
Message-ID: <1264620749-24527-2-git-send-email-adharmap@codeaurora.org> (raw)
In-Reply-To: <1264620749-24527-1-git-send-email-adharmap@codeaurora.org>

From: Abhijeet Dharmapurikar <adharmap@quicinc.com>

The gic code tries to initialize interrupts beyond NR_IRQ. Prevent
code from doing that.

Signed-off-by: Abhijeet Dharmapurikar <adharmap@quicinc.com>
---
 arch/arm/common/gic.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c
index 337741f..e763c4c 100644
--- a/arch/arm/common/gic.c
+++ b/arch/arm/common/gic.c
@@ -175,6 +175,11 @@ void __init gic_cascade_irq(unsigned int gic_nr, unsigned int irq)
 	set_irq_chained_handler(irq, gic_handle_cascade_irq);
 }
 
+/*
+ * In case of multiple cascaded GICs, order calls to gic_dist_init with
+ * ascending irq_start
+ */
+
 void __init gic_dist_init(unsigned int gic_nr, void __iomem *base,
 			  unsigned int irq_start)
 {
@@ -233,7 +238,7 @@ void __init gic_dist_init(unsigned int gic_nr, void __iomem *base,
 	/*
 	 * Setup the Linux IRQ subsystem.
 	 */
-	for (i = irq_start; i < gic_data[gic_nr].irq_offset + max_irq; i++) {
+	for (i = irq_start; i < NR_IRQS && i < gic_data[gic_nr].irq_offset + max_irq; i++) {
 		set_irq_chip(i, &gic_chip);
 		set_irq_chip_data(i, &gic_data[gic_nr]);
 		set_irq_handler(i, handle_level_irq);
-- 
1.5.6.3

  reply	other threads:[~2010-01-27 19:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 19:32 [PATCH 0/5] Arm Gic Changes adharmap
2010-01-27 19:32 ` adharmap
2010-01-27 19:32 ` adharmap at codeaurora.org
2010-01-27 19:32 ` adharmap [this message]
2010-01-27 19:32   ` [PATCH 1/5] gic: prevent gic from crossing NR_IRQ adharmap at codeaurora.org
2010-01-27 22:43   ` Russell King - ARM Linux
2010-01-27 22:43     ` Russell King - ARM Linux
2010-01-27 22:43     ` Russell King - ARM Linux
2010-01-28 13:19     ` Catalin Marinas
2010-01-28 13:19       ` Catalin Marinas
2010-01-27 19:32 ` [PATCH 2/5] gic: add callback for mask_ack adharmap
2010-01-27 19:32   ` adharmap
2010-01-27 19:32   ` adharmap at codeaurora.org
2010-01-27 19:32 ` [PATCH 3/5] gic: Add set_type callback adharmap
2010-01-27 19:32   ` adharmap at codeaurora.org
2010-01-27 23:09   ` Russell King - ARM Linux
2010-01-27 23:09     ` Russell King - ARM Linux
2010-01-27 23:09     ` Russell King - ARM Linux
2010-01-27 23:18   ` Russell King - ARM Linux
2010-01-27 23:18     ` Russell King - ARM Linux
2010-01-27 23:18     ` Russell King - ARM Linux
2010-01-28  1:43     ` Abhijeet Dharmapurikar
2010-01-28  1:43       ` Abhijeet Dharmapurikar
2010-05-07 10:56   ` Linus Walleij
2010-05-07 10:56     ` Linus Walleij
2010-01-27 19:32 ` [PATCH 4/5] gic: dont disable INT in ack callback adharmap
2010-01-27 19:32   ` adharmap at codeaurora.org
2010-01-27 19:32 ` [RFC PATCH 5/5] gic: initialize interrupts as per argument adharmap
2010-01-27 19:32   ` adharmap at codeaurora.org
2010-01-27 23:29   ` Russell King - ARM Linux
2010-01-27 23:29     ` Russell King - ARM Linux
2010-01-27 23:29     ` Russell King - ARM Linux
2010-01-28  0:39 ` [PATCH 0/5] Arm Gic Changes Ben Dooks
2010-01-28  0:39   ` Ben Dooks
2010-01-28  0:39   ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264620749-24527-2-git-send-email-adharmap@codeaurora.org \
    --to=adharmap@codeaurora.org \
    --cc=adharmap@quicinc.com \
    --cc=andrea.gallo@stericsson.com \
    --cc=catalin.marinas@arm.com \
    --cc=colin.tuckley@arm.com \
    --cc=jpihet@mvista.com \
    --cc=kalle.valo@iki.fi \
    --cc=khilman@deeprootsystems.com \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@elte.hu \
    --cc=pjohn@in.mvista.com \
    --cc=rubini@unipv.it \
    --cc=santosh.shilimkar@ti.com \
    --cc=srinidhi.kasagar@stericsson.com \
    --cc=tony@atomide.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.