From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mtd@lists.infradead.org, Leo Chen <leochen@broadcom.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: hot spin and code duplication in nand_bcm_umi_bch_read_oobEcc()
Date: Wed, 03 Feb 2010 18:22:55 +0200 [thread overview]
Message-ID: <1265214175.7343.108.camel@localhost> (raw)
In-Reply-To: <4B5A172C.2010609@gmail.com>
On Fri, 2010-01-22 at 22:22 +0100, Roel Kluin wrote:
> In the branch where pagesize equalled NAND_DATA_ACCESS_SIZE, NumToRead
> wasn't decremented in the `while (numToRead > 11)' loop.
> Also the first and last while loops were duplicated in both branches.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/mtd/nand/nand_bcm_umi.h | 71 ++++++++++++++-------------------------
> 1 files changed, 25 insertions(+), 46 deletions(-)
Taken to l2-mtd-2.6.git / dunno
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: Leo Chen <leochen@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: hot spin and code duplication in nand_bcm_umi_bch_read_oobEcc()
Date: Wed, 03 Feb 2010 18:22:55 +0200 [thread overview]
Message-ID: <1265214175.7343.108.camel@localhost> (raw)
In-Reply-To: <4B5A172C.2010609@gmail.com>
On Fri, 2010-01-22 at 22:22 +0100, Roel Kluin wrote:
> In the branch where pagesize equalled NAND_DATA_ACCESS_SIZE, NumToRead
> wasn't decremented in the `while (numToRead > 11)' loop.
> Also the first and last while loops were duplicated in both branches.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/mtd/nand/nand_bcm_umi.h | 71 ++++++++++++++-------------------------
> 1 files changed, 25 insertions(+), 46 deletions(-)
Taken to l2-mtd-2.6.git / dunno
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-02-03 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 21:22 [PATCH] mtd: hot spin and code duplication in nand_bcm_umi_bch_read_oobEcc() Roel Kluin
2010-01-22 22:04 ` Leo (Hao) Chen
2010-01-22 22:04 ` Leo (Hao) Chen
2010-02-03 16:22 ` Artem Bityutskiy [this message]
2010-02-03 16:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265214175.7343.108.camel@localhost \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=leochen@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.