From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: misplaced parenthesis in find_boot_record()
Date: Tue, 16 Feb 2010 11:09:29 +0200 [thread overview]
Message-ID: <1266311369.11659.201.camel@localhost> (raw)
In-Reply-To: <4B79C444.8090402@gmail.com>
On Mon, 2010-02-15 at 23:01 +0100, Roel Kluin wrote:
> The parenthesis was misplaced
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Not sure if you care about this one, it is between #if 0 ... #endif
>
> diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
> index 8b22b18..1ae6a02 100644
> --- a/drivers/mtd/nftlmount.c
> +++ b/drivers/mtd/nftlmount.c
> @@ -109,7 +109,7 @@ static int find_boot_record(struct NFTLrecord *nftl)
>
> /* Finally reread to check ECC */
> if ((ret = mtd->read(mtd, block * nftl->EraseSize, SECTORSIZE,
> - &retlen, buf) < 0)) {
> + &retlen, buf)) < 0) {
> printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but ECC read failed (err %d)\n",
> block * nftl->EraseSize, nftl->mbd.mtd->index, ret);
> continue;
Pushed both patches to my l2-mtd-2.6.git / master.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: misplaced parenthesis in find_boot_record()
Date: Tue, 16 Feb 2010 11:09:29 +0200 [thread overview]
Message-ID: <1266311369.11659.201.camel@localhost> (raw)
In-Reply-To: <4B79C444.8090402@gmail.com>
On Mon, 2010-02-15 at 23:01 +0100, Roel Kluin wrote:
> The parenthesis was misplaced
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Not sure if you care about this one, it is between #if 0 ... #endif
>
> diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
> index 8b22b18..1ae6a02 100644
> --- a/drivers/mtd/nftlmount.c
> +++ b/drivers/mtd/nftlmount.c
> @@ -109,7 +109,7 @@ static int find_boot_record(struct NFTLrecord *nftl)
>
> /* Finally reread to check ECC */
> if ((ret = mtd->read(mtd, block * nftl->EraseSize, SECTORSIZE,
> - &retlen, buf) < 0)) {
> + &retlen, buf)) < 0) {
> printk(KERN_NOTICE "ANAND header found at 0x%x in mtd%d, but ECC read failed (err %d)\n",
> block * nftl->EraseSize, nftl->mbd.mtd->index, ret);
> continue;
Pushed both patches to my l2-mtd-2.6.git / master.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-02-16 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 21:57 [PATCH] mtd: misplaced parenthesis in find_boot_record() Roel Kluin
2010-02-15 22:01 ` Roel Kluin
2010-02-15 22:01 ` Roel Kluin
2010-02-16 9:09 ` Artem Bityutskiy [this message]
2010-02-16 9:09 ` Artem Bityutskiy
2010-02-26 13:08 ` David Woodhouse
2010-02-26 13:08 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266311369.11659.201.camel@localhost \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.