bogus dependency from systemd to systemd-binfmt

bogus dependency from systemd to systemd-binfmt

[Andreas Schultz]

Hi,

With the current recipes a dependency from systemd to systemd-binfmt is
generated. systemd does work fine without systemd-binfmt and binfmt is
not required for a working system. So, this dependency should not be there.

The dependency is generated by systemd.bbclass because systemd-binfmt.service
has a 'Conflicts=shutdown.target' statement and systemd.bbclass does include
conflicting units into the package.

The cruel print are these lines in systemd.bbclass:

        if has_exactly_one_service:
            has_exactly_one_service = len(get_package_var(d, 'SYSTEMD_SERVICE', systemd_packages).split()) == 1

        keys = 'Also' # Conflicts??
        if has_exactly_one_service:
            # single service gets also the /dev/null dummies
            keys = 'Also Conflicts'

This might be correct for other systemd packages, but for systemd itself
this seems to be wrong....

Regards
Andreas

-- 
-- 
Dipl. Inform.
Andreas Schultz

Re: [poky] bogus dependency from systemd to systemd-binfmt

[Burton, Ross]

On 29 September 2014 15:29, Andreas Schultz <aschultz@tpip.net> wrote:
> With the current recipes a dependency from systemd to systemd-binfmt is
> generated. systemd does work fine without systemd-binfmt and binfmt is
> not required for a working system. So, this dependency should not be there.

It's more than just a bogus dependency:

$ rpm -qpl systemd-binfmt-216+git0+5d0ae62c66-r0.26.corei7_64.rpm
/etc
/etc/binfmt.d
/lib
/lib/systemd
/lib/systemd/system
/lib/systemd/system/proc-sys-fs-binfmt_misc.automount
/lib/systemd/system/proc-sys-fs-binfmt_misc.mount
/lib/systemd/system/shutdown.target
/lib/systemd/system/systemd-binfmt.service
/lib/systemd/systemd-binfmt
/usr
/usr/lib
/usr/lib/binfmt.d

Pretty certain shutdown.target doesn't belong in systemd-binfmt!

Right now I can't see a reason to move unit files around and add
dependencies based on *conflicts*, so I'll send a patch removing that
path entirely unless someone has a counter-argument.

Ross