All of lore.kernel.org
 help / color / mirror / Atom feed
From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: Assume new page cache pages have dirty D-cache
Date: Fri, 05 Mar 2010 15:32:09 +1100	[thread overview]
Message-ID: <1267763529.22204.90.camel@pasglop> (raw)
In-Reply-To: <20100304214435.GJ13417@n2100.arm.linux.org.uk>


> As I just realised, this is going to subject all pages placed into
> userspace with a D cache flush - even anonymous pages, and those
> which we've been careful to deal with the cache issues already (eg,
> via the COW page copying code.)
> 
> I think all the copypage functions need to set PG_dcache_clean on the
> new pages once their copy has completed.
> 
> I wonder if there's any other anonymous page creating functions which
> could do with a similar treatment...

Do we do anything other than COW and zero page ? clear_user_page() I
suppose could deal with that if you do the cache bits there.

Cheers,
Ben.

WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] ARM: Assume new page cache pages have dirty D-cache
Date: Fri, 05 Mar 2010 15:32:09 +1100	[thread overview]
Message-ID: <1267763529.22204.90.camel@pasglop> (raw)
In-Reply-To: <20100304214435.GJ13417@n2100.arm.linux.org.uk>


> As I just realised, this is going to subject all pages placed into
> userspace with a D cache flush - even anonymous pages, and those
> which we've been careful to deal with the cache issues already (eg,
> via the COW page copying code.)
> 
> I think all the copypage functions need to set PG_dcache_clean on the
> new pages once their copy has completed.
> 
> I wonder if there's any other anonymous page creating functions which
> could do with a similar treatment...

Do we do anything other than COW and zero page ? clear_user_page() I
suppose could deal with that if you do the cache bits there.

Cheers,
Ben.


  parent reply	other threads:[~2010-03-05  4:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-02 17:34 [RFC PATCH] ARM: Assume new page cache pages have dirty D-cache Catalin Marinas
2010-03-02 17:34 ` Catalin Marinas
2010-03-04 16:44 ` Russell King - ARM Linux
2010-03-04 16:44   ` Russell King - ARM Linux
2010-03-04 17:27   ` Catalin Marinas
2010-03-04 17:27     ` Catalin Marinas
2010-03-04 18:36   ` Catalin Marinas
2010-03-04 18:36     ` Catalin Marinas
2010-03-04 21:44     ` Russell King - ARM Linux
2010-03-04 21:44       ` Russell King - ARM Linux
2010-03-05  1:28       ` Paul Mundt
2010-03-05  1:28         ` Paul Mundt
2010-03-05  4:46         ` Benjamin Herrenschmidt
2010-03-05  4:46           ` Benjamin Herrenschmidt
2010-03-05  4:32       ` Benjamin Herrenschmidt [this message]
2010-03-05  4:32         ` Benjamin Herrenschmidt
2010-03-05 16:52       ` Catalin Marinas
2010-03-05 16:52         ` Catalin Marinas
2010-03-05 21:16         ` Russell King - ARM Linux
2010-03-05 21:16           ` Russell King - ARM Linux
2010-03-06 10:00           ` Catalin Marinas
2010-03-06 10:00             ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267763529.22204.90.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.