* block: blk-timeout.c possible mishandling of jiffies wrap?
@ 2010-03-07 17:47 Richard Kennedy
0 siblings, 0 replies; only message in thread
From: Richard Kennedy @ 2010-03-07 17:47 UTC (permalink / raw)
To: Jens Axboe; +Cc: lkml
Hi Jens,
In blk_rq_timed_out_timer() in blk-timeout.c the comment at line 129
says that the request deadline can never be zero as that gets fixed in
blk_add_timer.
However commit 7838c15b8dd18e78a523513749e5b54bda07b0cb
removed the line that bumped deadline if zero.
So now AFAICT there's nothing to prevent deadline being zero, and
blk_rq_timed_out_timer may not always do the right thing when jiffies is
about to wrap.
There was a next_set flag in blk_rq_timed_out_timer but that's been
removed too.
Do you have any preferred fix? A next_set flag or a deadline bump or
something else?
regards
Richard
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-07 17:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-07 17:47 block: blk-timeout.c possible mishandling of jiffies wrap? Richard Kennedy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.