All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Bing Zhao <bzhao@marvell.com>, Rahul Tank <rahult@marvell.com>,
	Amitkumar Karwar <akarwar@marvell.com>,
	linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] bluetooth: storing negative values as unsigned char
Date: Tue, 09 Mar 2010 00:54:50 +0000	[thread overview]
Message-ID: <1268096091.3712.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20100308121559.GG6469@bicker>

Hi Dan,

> This is mostly cleanup.  There is only one caller and it just checks for 
> non-zero return values.  Still "ret" should be int because we want to return 
> -EINVAL on errors.

patch has been applied. Thanks.

Regards

Marcel



WARNING: multiple messages have this Message-ID (diff)
From: Marcel Holtmann <marcel@holtmann.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Bing Zhao <bzhao@marvell.com>, Rahul Tank <rahult@marvell.com>,
	Amitkumar Karwar <akarwar@marvell.com>,
	linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] bluetooth: storing negative values as unsigned char
Date: Mon, 08 Mar 2010 16:54:50 -0800	[thread overview]
Message-ID: <1268096091.3712.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20100308121559.GG6469@bicker>

Hi Dan,

> This is mostly cleanup.  There is only one caller and it just checks for 
> non-zero return values.  Still "ret" should be int because we want to return 
> -EINVAL on errors.

patch has been applied. Thanks.

Regards

Marcel



  reply	other threads:[~2010-03-09  0:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 12:15 [patch] bluetooth: storing negative values as unsigned char Dan Carpenter
2010-03-08 12:15 ` Dan Carpenter
2010-03-09  0:54 ` Marcel Holtmann [this message]
2010-03-09  0:54   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268096091.3712.30.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=akarwar@marvell.com \
    --cc=bzhao@marvell.com \
    --cc=error27@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=rahult@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.