From: Mike Galbraith <efault@gmx.de>
To: Yong Zhang <yong.zhang@windriver.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
a.p.zijlstra@chello.nl, tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched: Remove AFFINE_WAKEUPS feature
Date: Fri, 12 Mar 2010 05:37:19 +0100 [thread overview]
Message-ID: <1268368639.6302.2.camel@marge.simson.net> (raw)
In-Reply-To: <20100312032333.GA13021@windriver.com>
On Fri, 2010-03-12 at 11:23 +0800, Yong Zhang wrote:
> On Thu, Mar 11, 2010 at 06:33:38PM +0000, tip-bot for Mike Galbraith wrote:
> > Commit-ID: beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
> > Gitweb: http://git.kernel.org/tip/beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
> > Author: Mike Galbraith <efault@gmx.de>
> > AuthorDate: Thu, 11 Mar 2010 17:17:20 +0100
> > Committer: Ingo Molnar <mingo@elte.hu>
> > CommitDate: Thu, 11 Mar 2010 18:32:53 +0100
> >
> > sched: Remove AFFINE_WAKEUPS feature
> >
> > Disabling affine wakeups is too horrible to contemplate. Remove the feature flag.
>
> AFFINE_WAKEUPS is still left in sched_feature.h
Oops, axe got dull. Thanks for checking.
-Mike
> From: Yong Zhang <yong.zhang@windriver.com>
> Date: Fri, 12 Mar 2010 11:14:26 +0800
> Subject: [PATCH] sched: clean AFFINE_WAKEUPS feature
>
> complementary work to commit beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8
>
> Signed-off-by: Yong Zhang <yong.zhang@windriver.com>
> ---
> kernel/sched_features.h | 8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/sched_features.h b/kernel/sched_features.h
> index 83c66e8..2137ac0 100644
> --- a/kernel/sched_features.h
> +++ b/kernel/sched_features.h
> @@ -17,14 +17,6 @@ SCHED_FEAT(START_DEBIT, 1)
> SCHED_FEAT(WAKEUP_PREEMPT, 1)
>
> /*
> - * Based on load and program behaviour, see if it makes sense to place
> - * a newly woken task on the same cpu as the task that woke it --
> - * improve cache locality. Typically used with SYNC wakeups as
> - * generated by pipes and the like, see also SYNC_WAKEUPS.
> - */
> -SCHED_FEAT(AFFINE_WAKEUPS, 1)
> -
> -/*
> * Prefer to schedule the task we woke last (assuming it failed
> * wakeup-preemption), since its likely going to consume data we
> * touched, increases cache locality.
prev parent reply other threads:[~2010-03-12 4:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 9:49 [patch 0/12] sched: fastpath cycle recovery Mike Galbraith
2010-03-11 9:50 ` [patch 1/12] sched: ratelimit nohz Mike Galbraith
2010-03-11 18:30 ` [tip:sched/core] sched: Rate-limit nohz tip-bot for Mike Galbraith
2010-03-11 9:51 ` [patch 2/12] sched: remove avg_wakeup Mike Galbraith
2010-03-11 18:30 ` [tip:sched/core] sched: Remove avg_wakeup tip-bot for Mike Galbraith
2010-03-11 9:52 ` [patch 3/12] sched: remove avg_overlap Mike Galbraith
2010-03-11 18:31 ` [tip:sched/core] sched: Remove avg_overlap tip-bot for Mike Galbraith
2010-03-11 9:53 ` [patch 4/12] sched: cleanup/optimize clock updates Mike Galbraith
2010-03-11 18:31 ` [tip:sched/core] sched: Cleanup/optimize " tip-bot for Mike Galbraith
2010-03-11 9:54 ` [patch 5/12] sched: tweak sched_latency and min_granularity Mike Galbraith
2010-03-11 18:31 ` [tip:sched/core] sched: Tweak " tip-bot for Mike Galbraith
2010-03-11 9:56 ` [patch 6/12] sched: fix select_idle_sibling() Mike Galbraith
2010-03-11 18:32 ` [tip:sched/core] sched: Fix select_idle_sibling() tip-bot for Mike Galbraith
2010-03-11 9:57 ` [patch 7/12] sched: remove NORMALIZED_SLEEPER Mike Galbraith
2010-03-11 18:32 ` [tip:sched/core] sched: Remove NORMALIZED_SLEEPER tip-bot for Mike Galbraith
2010-03-11 9:58 ` [patch 8/12] sched: remove FAIR_SLEEPERS feature Mike Galbraith
2010-03-11 18:32 ` [tip:sched/core] sched: Remove " tip-bot for Mike Galbraith
2010-03-11 9:59 ` [patch 9/12] sched: remove WAKEUP_SYNC feature Mike Galbraith
2010-03-11 18:32 ` [tip:sched/core] sched: Remove " tip-bot for Mike Galbraith
2010-03-11 10:01 ` [patch 11/12] sched: remove ASYM_GRAN feature Mike Galbraith
2010-03-11 18:33 ` [tip:sched/core] sched: Remove " tip-bot for Mike Galbraith
2010-03-11 10:03 ` [patch 10/12] sched: remove SYNC_WAKEUPS feature Mike Galbraith
2010-03-11 18:33 ` [tip:sched/core] sched: Remove " tip-bot for Mike Galbraith
2010-03-11 10:04 ` [patch 12/12] sched: remove AFFINE_WAKEUPS feature Mike Galbraith
2010-03-11 18:33 ` [tip:sched/core] sched: Remove " tip-bot for Mike Galbraith
2010-03-12 3:23 ` Yong Zhang
2010-03-12 4:37 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268368639.6302.2.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yong.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.