All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Bruno Randolf <randolf.bruno@googlemail.com>
Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] mac80211: Revise,pending queue depth in ieee80211_local data structure
Date: Mon, 22 Mar 2010 11:12:44 -0700	[thread overview]
Message-ID: <1269281564.7645.1.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <201003211101.16481.randolf.bruno@gmail.com>

On Sun, 2010-03-21 at 11:01 +0900, Bruno Randolf wrote:
> On Sunday 21 March 2010 05:40:05 Johannes Berg wrote:
> > On Sat, 2010-03-20 at 21:02 +0100, Lorenzo Bianconi wrote:
> > > >> setup 2 wireless cards, talking to each other (i use IBSS) on
> > > >> different
> > > 
> > > >> machines. then setup routing like this:
> > > PC1<--ethernet cable-->Device1<--wireless link-->Device2<--ethernet
> > > cable-->PC2
> > 
> > I'm not really sure how this scenario differs from injecting traffic
> > locally, but I'll try to reproduce.
> 
> if you generate traffic locally it's enough to stop the queues, this will 
> cause userspace to stop generating traffic. in the forwarding case (which we 
> are talking about) stopping the queues will not stop the sender to send 
> traffic, thus we have to start dropping packets at some point. 

So I tried this scenario, and I see the queues stopping, and traffic
being dropped quite as you'd want it. Even the race condition that I
noticed didn't ever trigger.

Please make sure you're using a kernel recent enough to include the
fixes, maybe try compat-wireless.

johannes


  parent reply	other threads:[~2010-03-22 18:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 15:43 [PATCH V2] mac80211: Revise,pending queue depth in ieee80211_local data structure lorenzo.bianconi83@gmail.com
2010-03-18 16:19 ` Johannes Berg
2010-03-18 18:12 ` Johannes Berg
2010-03-18 18:20 ` Johannes Berg
2010-03-19  9:33   ` lorenzo.bianconi83@gmail.com
2010-03-19 18:49     ` Johannes Berg
2010-03-20  2:44       ` Bruno Randolf
2010-03-20  3:07         ` Bruno Randolf
2010-03-20 20:02           ` Lorenzo Bianconi
2010-03-20 20:40             ` Johannes Berg
2010-03-21  2:01               ` Bruno Randolf
2010-03-21  2:22                 ` Johannes Berg
2010-03-22 18:12                 ` Johannes Berg [this message]
2010-03-31  8:12                   ` Bruno Randolf
2010-03-31  8:13                     ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2010-03-18 15:32 lorenzo.bianconi83@gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269281564.7645.1.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=randolf.bruno@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.