From: Johannes Berg <johannes@sipsolutions.net>
To: "lorenzo.bianconi83@gmail.com" <lorenzo.bianconi@fluidmesh.com>
Cc: <linux-wireless@vger.kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Bruno Randolf <br1@einfach.org>, Tony Huang <ht6100@gmail.com>
Subject: Re: [PATCH V2] mac80211: Revise,pending queue depth in ieee80211_local data structure
Date: Fri, 19 Mar 2010 19:49:27 +0100 [thread overview]
Message-ID: <a0b9368788449213d36b75dccd97c6a6@localhost> (raw)
In-Reply-To: <4BA344FB.1090500@gmail.com>
On Fri, 19 Mar 2010 10:33:47 +0100, "lorenzo.bianconi83@gmail.com"
>> if (!skb_queue_empty(&local->pending[queue]))
>> tasklet_schedule(&local->tx_pending_tasklet);
>> -
>> - rcu_read_lock();
>> - list_for_each_entry_rcu(sdata, &local->interfaces, list)
>> - netif_tx_wake_queue(netdev_get_tx_queue(sdata->dev, queue));
>> - rcu_read_unlock();
That's obviously wrong, need to move the code to the else branch of the
above if instead.
> I tested the patch on kernel 2.6.32.7 with compat-wireless-2010-03-03
but
> it seems that the problem is not solved. If I set the lowest priority
queue
> (Backgreound), the system will crash for an out of memory panic. During
the
> tests I carried out, I transmit 50Mbps UDP traffic.
How are you generating traffic? I just dumped like 2Gbps traffic at it
and everything works just fine. I verified queues are stopped and started
properly.
johannes
next prev parent reply other threads:[~2010-03-19 18:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 15:43 [PATCH V2] mac80211: Revise,pending queue depth in ieee80211_local data structure lorenzo.bianconi83@gmail.com
2010-03-18 16:19 ` Johannes Berg
2010-03-18 18:12 ` Johannes Berg
2010-03-18 18:20 ` Johannes Berg
2010-03-19 9:33 ` lorenzo.bianconi83@gmail.com
2010-03-19 18:49 ` Johannes Berg [this message]
2010-03-20 2:44 ` Bruno Randolf
2010-03-20 3:07 ` Bruno Randolf
2010-03-20 20:02 ` Lorenzo Bianconi
2010-03-20 20:40 ` Johannes Berg
2010-03-21 2:01 ` Bruno Randolf
2010-03-21 2:22 ` Johannes Berg
2010-03-22 18:12 ` Johannes Berg
2010-03-31 8:12 ` Bruno Randolf
2010-03-31 8:13 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2010-03-18 15:32 lorenzo.bianconi83@gmail.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0b9368788449213d36b75dccd97c6a6@localhost \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=br1@einfach.org \
--cc=ht6100@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@fluidmesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.