* [PATCH] dma: timb-dma: Update comment and fix compiler warning
@ 2010-03-26 7:23 Richard Röjfors
0 siblings, 0 replies; only message in thread
From: Richard Röjfors @ 2010-03-26 7:23 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Samuel Ortiz, Williams, Dan J, "Dan J <dan.j.williams"
An incremental patch which clarifies what the spinlock is used for
and fixes a compiler warning.
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
index 4dd7102..145f1c2 100644
--- a/drivers/dma/timb_dma.c
+++ b/drivers/dma/timb_dma.c
@@ -79,7 +79,10 @@ struct timb_dma_desc {
struct timb_dma_chan {
struct dma_chan chan;
void __iomem *membase;
- spinlock_t lock; /* Used for mutual exclusion */
+ spinlock_t lock; /* Used to protect data structures,
+ especially the lists and descriptors,
+ from races between the tasklet and calls
+ from above */
dma_cookie_t last_completed_cookie;
bool ongoing;
struct list_head active_list;
@@ -197,7 +200,7 @@ static int td_fill_desc(struct timb_dma_chan *td_chan, u8 *dma_desc,
}
dev_dbg(chan2dev(&td_chan->chan), "desc: %p, addr: %p\n",
- dma_desc, (void *)(int)sg_dma_address(sg));
+ dma_desc, (void *)sg_dma_address(sg));
dma_desc[7] = (sg_dma_address(sg) >> 24) & 0xff;
dma_desc[6] = (sg_dma_address(sg) >> 16) & 0xff;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-26 7:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-26 7:23 [PATCH] dma: timb-dma: Update comment and fix compiler warning Richard Röjfors
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.