All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] lockdep: Make lockstats counting per cpu
Date: Fri, 26 Mar 2010 08:48:34 +0100	[thread overview]
Message-ID: <1269589714.12097.122.camel@laptop> (raw)
In-Reply-To: <1269586358.12097.117.camel@laptop>

On Fri, 2010-03-26 at 07:52 +0100, Peter Zijlstra wrote:
> On Fri, 2010-03-26 at 03:22 +0100, Frederic Weisbecker wrote:
> > We can't use irqsafe per cpu counters for that as
> > these stats might be also written from NMI path, and irqsafe per
> > cpu counters are not NMI safe, but local_t operations are.
> > 
> lockdep shouldn't do NMI, nmi_enter() has an explicit lockdep_off().

Also, more importantly, you simply should never use locks in NMI context
to begin with ;-)


  reply	other threads:[~2010-03-26  7:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-26  2:22 [PATCH] lockdep: Make lockstats counting per cpu Frederic Weisbecker
2010-03-26  3:11 ` Frederic Weisbecker
2010-03-26  3:13   ` Frederic Weisbecker
2010-03-26  9:16   ` Ingo Molnar
2010-03-26 17:11     ` Frederic Weisbecker
2010-03-26  6:52 ` Peter Zijlstra
2010-03-26  7:48   ` Peter Zijlstra [this message]
2010-03-26 17:43     ` Frederic Weisbecker
2010-03-26 17:39   ` Frederic Weisbecker
  -- strict thread matches above, loose matches on Subject: below --
2010-03-28  0:29 [PATCH v3] " Frederic Weisbecker
2010-04-05 22:10 ` [PATCH] " Frederic Weisbecker
2010-04-06  8:46   ` Peter Zijlstra
2010-04-06  9:24     ` Frederic Weisbecker
2010-04-06  9:25     ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269589714.12097.122.camel@laptop \
    --to=peterz@infradead.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.