Re: [PATCH] lockdep: Make lockstats counting per cpu

[Frederic Weisbecker <fweisbec@gmail.com>]

On Fri, Mar 26, 2010 at 10:16:39AM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > +DEFINE_PER_CPU(local_t, chain_lookup_hits);
> > +DEFINE_PER_CPU(local_t, chain_lookup_misses);
> > +DEFINE_PER_CPU(local_t, hardirqs_on_events);
> > +DEFINE_PER_CPU(local_t, hardirqs_off_events);
> > +DEFINE_PER_CPU(local_t, redundant_hardirqs_on);
> > +DEFINE_PER_CPU(local_t, redundant_hardirqs_off);
> > +DEFINE_PER_CPU(local_t, softirqs_on_events);
> > +DEFINE_PER_CPU(local_t, softirqs_off_events);
> > +DEFINE_PER_CPU(local_t, redundant_softirqs_on);
> > +DEFINE_PER_CPU(local_t, redundant_softirqs_off);
> > +DEFINE_PER_CPU(local_t, nr_unused_locks);
> > +DEFINE_PER_CPU(local_t, nr_cyclic_checks);
> > +DEFINE_PER_CPU(local_t, nr_find_usage_forwards_checks);
> > +DEFINE_PER_CPU(local_t, nr_find_usage_backwards_checks);
> 
> btw., i think this should really be cleaned up and put into a helper struct.
> 
> 'struct lockdep_stats' or so?



Yep, looks like a good idea.