All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: Daniel Mack <daniel@caiaq.de>,
	libertas-dev@lists.infradead.org, netdev@vger.kernel.org,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] net/wireless/libertas: do not call wiphy_unregister() w/o wiphy_register()
Date: Tue, 30 Mar 2010 10:04:33 -0700	[thread overview]
Message-ID: <1269968673.3019.37.camel@localhost.localdomain> (raw)
In-Reply-To: <201003301259.23973.hs4233@mail.mn-solutions.de>

On Tue, 2010-03-30 at 12:59 +0200, Holger Schurig wrote:
> > I don't get your point. The patch I submitted fixes an Ooops in the
> > driver, due to wrong handling of an API. What does that have to do with
> > principle discussions about the frameworks in use?
> 
> I asked if there is a better method, and you said that you would test a better 
> solution. That means that someone else should make a better solution.
> 
> I just pointed out that I won't be the one who creates the better solution, 
> because for fundamental reasons I don't see the libertas+cfg80211 approach 
> going forward. That issue has nothing to do with you or your patch, so please 
> don't feel offended or confused.

Fine; just rip out the mesh code and do the vanilla cfg80211 conversion
for infra & adhoc, and we'll add the mesh code back later.  I don't have
time to do the cfg80211 bits, neither do the OLPC guys (AFAIK), so lets
take advantage of your willingness to do this and just move the driver
forward.

Dan

> 
> Basically, I neither ack nor nak you patch. Given that it fixes an oops the 
> patch should go in, and probably to stable at well. I just gave a hint, to 
> make you think if you could come up with something better.
> 
> 
> 
> BTW, testing/fixing of failure paths in libertas as well as simplifying the 
> call sequence of functions during initialisation could be quite useful.
> 
> _______________________________________________
> libertas-dev mailing list
> libertas-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libertas-dev



WARNING: multiple messages have this Message-ID (diff)
From: Dan Williams <dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Holger Schurig
	<hs4233-x6+DxXLjN1AJvtFkdXX2Hg4jNU5vUVPG@public.gmane.org>
Cc: Daniel Mack <daniel-rDUAYElUppE@public.gmane.org>,
	libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"John W. Linville"
	<linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH] net/wireless/libertas: do not call wiphy_unregister() w/o wiphy_register()
Date: Tue, 30 Mar 2010 10:04:33 -0700	[thread overview]
Message-ID: <1269968673.3019.37.camel@localhost.localdomain> (raw)
In-Reply-To: <201003301259.23973.hs4233-x6+DxXLjN1AJvtFkdXX2Hg4jNU5vUVPG@public.gmane.org>

On Tue, 2010-03-30 at 12:59 +0200, Holger Schurig wrote:
> > I don't get your point. The patch I submitted fixes an Ooops in the
> > driver, due to wrong handling of an API. What does that have to do with
> > principle discussions about the frameworks in use?
> 
> I asked if there is a better method, and you said that you would test a better 
> solution. That means that someone else should make a better solution.
> 
> I just pointed out that I won't be the one who creates the better solution, 
> because for fundamental reasons I don't see the libertas+cfg80211 approach 
> going forward. That issue has nothing to do with you or your patch, so please 
> don't feel offended or confused.

Fine; just rip out the mesh code and do the vanilla cfg80211 conversion
for infra & adhoc, and we'll add the mesh code back later.  I don't have
time to do the cfg80211 bits, neither do the OLPC guys (AFAIK), so lets
take advantage of your willingness to do this and just move the driver
forward.

Dan

> 
> Basically, I neither ack nor nak you patch. Given that it fixes an oops the 
> patch should go in, and probably to stable at well. I just gave a hint, to 
> make you think if you could come up with something better.
> 
> 
> 
> BTW, testing/fixing of failure paths in libertas as well as simplifying the 
> call sequence of functions during initialisation could be quite useful.
> 
> _______________________________________________
> libertas-dev mailing list
> libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/libertas-dev


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-03-30 17:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 15:14 [PATCH] net/wireless/libertas: do not call wiphy_unregister() w/o wiphy_register() Daniel Mack
2010-03-29 15:14 ` Daniel Mack
2010-03-30  6:49 ` Holger Schurig
2010-03-30  8:52   ` Daniel Mack
2010-03-30  9:49     ` Holger Schurig
2010-03-30 10:50       ` Daniel Mack
2010-03-30 10:59         ` Holger Schurig
2010-03-30 17:04           ` Dan Williams [this message]
2010-03-30 17:04             ` Dan Williams
2010-03-30 17:20             ` John W. Linville
2010-04-08 19:03               ` John W. Linville
2010-04-09 13:51                 ` Holger Schurig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269968673.3019.37.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=daniel@caiaq.de \
    --cc=hs4233@mail.mn-solutions.de \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.