All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Bohan <mbohan@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org
Cc: mel@csn.ul.ie, Michael Bohan <mbohan@quicinc.com>,
	Michael Bohan <mbohan@codeaurora.org>
Subject: [PATCH 1/3] arm: mm: Update mem bank ordering comment to reflect code
Date: Thu,  1 Apr 2010 17:20:47 -0700	[thread overview]
Message-ID: <1270167649-17824-1-git-send-email-mbohan@codeaurora.org> (raw)
In-Reply-To: <>

From: Michael Bohan <mbohan@quicinc.com>

The memory banks are now sorted in bootmem_init() -- thus this
code no longer needs fixing.

Change-Id: Idc20f9c34bef416544081c3b5cf33fe120c63759
Signed-off-by: Michael Bohan <mbohan@quicinc.com>
Signed-off-by: Michael Bohan <mbohan@codeaurora.org>
---
 arch/arm/mm/init.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 7829cb5..ab4890f 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -531,9 +531,8 @@ static void __init free_unused_memmap_node(int node, struct meminfo *mi)
 	unsigned int i;
 
 	/*
-	 * [FIXME] This relies on each bank being in address order.  This
-	 * may not be the case, especially if the user has provided the
-	 * information on the command line.
+	 * This relies on each bank being in address order. The banks
+	 * are sorted previously in bootmem_init().
 	 */
 	for_each_nodebank(i, mi, node) {
 		struct membank *bank = &mi->bank[i];
-- 
1.6.2.3


WARNING: multiple messages have this Message-ID (diff)
From: mbohan@codeaurora.org (Michael Bohan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm: mm: Update mem bank ordering comment to reflect code
Date: Thu,  1 Apr 2010 17:20:47 -0700	[thread overview]
Message-ID: <1270167649-17824-1-git-send-email-mbohan@codeaurora.org> (raw)
In-Reply-To: <>

From: Michael Bohan <mbohan@quicinc.com>

The memory banks are now sorted in bootmem_init() -- thus this
code no longer needs fixing.

Change-Id: Idc20f9c34bef416544081c3b5cf33fe120c63759
Signed-off-by: Michael Bohan <mbohan@quicinc.com>
Signed-off-by: Michael Bohan <mbohan@codeaurora.org>
---
 arch/arm/mm/init.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
index 7829cb5..ab4890f 100644
--- a/arch/arm/mm/init.c
+++ b/arch/arm/mm/init.c
@@ -531,9 +531,8 @@ static void __init free_unused_memmap_node(int node, struct meminfo *mi)
 	unsigned int i;
 
 	/*
-	 * [FIXME] This relies on each bank being in address order.  This
-	 * may not be the case, especially if the user has provided the
-	 * information on the command line.
+	 * This relies on each bank being in address order. The banks
+	 * are sorted previously in bootmem_init().
 	 */
 	for_each_nodebank(i, mi, node) {
 		struct membank *bank = &mi->bank[i];
-- 
1.6.2.3

             reply	other threads:[~2010-04-02  0:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02  0:20 Michael Bohan [this message]
2010-04-02  0:20 ` [PATCH 1/3] arm: mm: Update mem bank ordering comment to reflect code Michael Bohan
2010-04-02  0:20 ` [PATCH 2/3] arm: Add config option for HOLES_IN_ZONE Michael Bohan
2010-04-02  0:20   ` Michael Bohan
2010-04-02  0:20   ` [PATCH 3/3] arm: mm: Add alignment check for memory banks in FLATMEM Michael Bohan
2010-04-02  0:20     ` Michael Bohan
2010-04-02  9:56   ` [PATCH 2/3] arm: Add config option for HOLES_IN_ZONE Mel Gorman
2010-04-02  9:56     ` Mel Gorman
2010-04-02 19:20     ` Michael Bohan
2010-04-02 19:20       ` Michael Bohan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270167649-17824-1-git-send-email-mbohan@codeaurora.org \
    --to=mbohan@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=mbohan@quicinc.com \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.