From: Dave Wysochanski <dwysocha@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 4/6] Add pv->vg to solidify link between a pv and a vg.
Date: Mon, 05 Apr 2010 11:13:09 -0400 [thread overview]
Message-ID: <1270480389.14700.1.camel@f10-node1> (raw)
In-Reply-To: <20100402012345.GX11377@agk-dp.fab.redhat.com>
On Fri, 2010-04-02 at 02:23 +0100, Alasdair G Kergon wrote:
> On Thu, Apr 01, 2010 at 05:57:30PM -0400, Dave Wysochanski wrote:
> > lvm2app needs a link back to the vg in order to use the vg handle for
> > memory allocations as well as other things. This patch adds the field
> > to struct physical_volume, and sets the field when returning from
> > vg_read() internal library call.
>
> > + struct volume_group *vg; /* FIXME: Only valid when used with lvm2app. */
>
> Please make it generally applicable and always internally consistent i.e.
> always pointing back to the VG struct which contains the list it is on.
>
Oh - this FIXME is an erroneous comment - sorry. Originally I had
approached it this way, then changed it to be more general. I could
have missed something though.
> Also update vg_validate whenever extending the core metadata structs.
>
Will do so - thanks for the reminder.
prev parent reply other threads:[~2010-04-05 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 21:57 [PATCH 0/6] Add pv->vg link, rework lvm2app string properties Dave Wysochanski
2010-04-01 21:57 ` [PATCH 1/6] Add pv to vg->pvs after check for maximum value of vg->extent_count Dave Wysochanski
2010-04-01 21:57 ` [PATCH 2/6] Refactor _read_pv() code adding pv to vg->pvs and updating vg counts Dave Wysochanski
2010-04-01 21:57 ` [PATCH 3/6] Add add_pvl_to_vgs() - helper function to add a pv to a vg list Dave Wysochanski
2010-04-01 21:57 ` [PATCH 4/6] Add pv->vg to solidify link between a pv and a vg Dave Wysochanski
2010-04-01 21:57 ` [PATCH 5/6] Use vg->vgmem to allocate vg/lv/pv string properties instead of dm_malloc/free Dave Wysochanski
2010-04-01 21:57 ` [PATCH 6/6] RFC: Change lvm2app version number from 1 to 2 Dave Wysochanski
2010-04-02 11:39 ` Milan Broz
2010-04-05 3:03 ` Dave Wysochanski
2010-04-02 1:23 ` [PATCH 4/6] Add pv->vg to solidify link between a pv and a vg Alasdair G Kergon
2010-04-05 15:13 ` Dave Wysochanski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270480389.14700.1.camel@f10-node1 \
--to=dwysocha@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.