From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 6/6] RFC: Change lvm2app version number from 1 to 2.
Date: Fri, 02 Apr 2010 13:39:38 +0200 [thread overview]
Message-ID: <4BB5D77A.2090409@redhat.com> (raw)
In-Reply-To: <1270159052-1181-7-git-send-email-dwysocha@redhat.com>
On 04/01/2010 11:57 PM, Dave Wysochanski wrote:
> This version number change reflects the memory handling change
> for string-based pv/vg/lv string based attributes.
Maybe it is better idea to use VG mempool, maybe not for
VG attributes.
But change it now, it means that application using
calls which previously deallocates these attributes with dm_free
will now crash, because the memory returned is now owned
by library.
I really do not like changing API this way in every release...
I see three API possibilities
- define buffer parameter, so all memory allocations are
in user application
- return strings/parameters *CONST* and define that lvm2app
owns memory
- use dm_malloc, and require dm_free in user aplications.
But please do not change this later!
It is extremely confusing for library users,
no warning that API is not stable will not help here...
Milan
next prev parent reply other threads:[~2010-04-02 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 21:57 [PATCH 0/6] Add pv->vg link, rework lvm2app string properties Dave Wysochanski
2010-04-01 21:57 ` [PATCH 1/6] Add pv to vg->pvs after check for maximum value of vg->extent_count Dave Wysochanski
2010-04-01 21:57 ` [PATCH 2/6] Refactor _read_pv() code adding pv to vg->pvs and updating vg counts Dave Wysochanski
2010-04-01 21:57 ` [PATCH 3/6] Add add_pvl_to_vgs() - helper function to add a pv to a vg list Dave Wysochanski
2010-04-01 21:57 ` [PATCH 4/6] Add pv->vg to solidify link between a pv and a vg Dave Wysochanski
2010-04-01 21:57 ` [PATCH 5/6] Use vg->vgmem to allocate vg/lv/pv string properties instead of dm_malloc/free Dave Wysochanski
2010-04-01 21:57 ` [PATCH 6/6] RFC: Change lvm2app version number from 1 to 2 Dave Wysochanski
2010-04-02 11:39 ` Milan Broz [this message]
2010-04-05 3:03 ` Dave Wysochanski
2010-04-02 1:23 ` [PATCH 4/6] Add pv->vg to solidify link between a pv and a vg Alasdair G Kergon
2010-04-05 15:13 ` Dave Wysochanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB5D77A.2090409@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.